Adding a FINAL_STATUS_IN_PROGRESS to replace FINAL_STATUS_MAX
Because MAX changes value every time a new final status is added,
looking at UMA/UKM is tricky. MAX is now replaced with IN_PROGRESS that
will represent the state the prefetch is in before it finishes due to
some other final state.
Change-Id: I595d8cfcdb5e165d85c4d88684b8c96080ae4337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553815
Commit-Queue: Ryan Sturm <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#648405}diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc
index 68a50e9..1cade10 100644
--- a/chrome/browser/prerender/prerender_contents.cc
+++ b/chrome/browser/prerender/prerender_contents.cc
@@ -182,7 +182,7 @@
referrer_(referrer),
profile_(profile),
has_finished_loading_(false),
- final_status_(FINAL_STATUS_MAX),
+ final_status_(FINAL_STATUS_UNKNOWN),
prerendering_has_been_cancelled_(false),
process_pid_(base::kNullProcessId),
child_id_(-1),
@@ -312,13 +312,13 @@
DCHECK_GE(final_status, FINAL_STATUS_USED);
DCHECK_LT(final_status, FINAL_STATUS_MAX);
- DCHECK_EQ(FINAL_STATUS_MAX, final_status_);
+ DCHECK_EQ(FINAL_STATUS_UNKNOWN, final_status_);
final_status_ = final_status;
}
PrerenderContents::~PrerenderContents() {
- DCHECK_NE(FINAL_STATUS_MAX, final_status());
+ DCHECK_NE(FINAL_STATUS_UNKNOWN, final_status());
DCHECK(
prerendering_has_been_cancelled() || final_status() == FINAL_STATUS_USED);
DCHECK_NE(ORIGIN_MAX, origin());
@@ -351,7 +351,7 @@
}
void PrerenderContents::AddObserver(Observer* observer) {
- DCHECK_EQ(FINAL_STATUS_MAX, final_status_);
+ DCHECK_EQ(FINAL_STATUS_UNKNOWN, final_status_);
observer_list_.AddObserver(observer);
}
@@ -410,7 +410,7 @@
}
void PrerenderContents::NotifyPrerenderStart() {
- DCHECK_EQ(FINAL_STATUS_MAX, final_status_);
+ DCHECK_EQ(FINAL_STATUS_UNKNOWN, final_status_);
for (Observer& observer : observer_list_)
observer.OnPrerenderStart(this);
}
@@ -426,7 +426,7 @@
}
void PrerenderContents::NotifyPrerenderStop() {
- DCHECK_NE(FINAL_STATUS_MAX, final_status_);
+ DCHECK_NE(FINAL_STATUS_UNKNOWN, final_status_);
for (Observer& observer : observer_list_)
observer.OnPrerenderStop(this);
observer_list_.Clear();
