[omnibox] Add back on device head suggestions flags for Win
This is a temporary solution for some corp users (e.g. in crbug/1307005) experiencing severe omnibox input lags when their mandatory anti virus software running in the background (such that they can manually disable the feature when lags happen).
Their anti-virus is very likely blocking local file access while on device head suggest might issue multiple ifstream reads on each keystroke in ThreadPool at the same time. As a result, the performance of the ThreadPool could become very poor in this case which might in turn hurt the overall performance of Chrome (though theoretically this should not cause UI lags as reads only happen in ThreadPool).
Users report in crbug/1307005 lags goes away once either AV or on device head is turned off.
Bug: 1307005
Change-Id: I48d4ba073a07c8fb652b62e16ac101a31b64706d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708095
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1015347}
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 07843592..96ac4e5 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -1844,6 +1844,21 @@
"in the HTTP cache. If no or zero duration is provided, the existing "
"in-memory cache will used instead of HTTP cache.";
+const char kOmniboxOnDeviceHeadSuggestionsName[] =
+ "Omnibox on device head suggestions (non-incognito only)";
+const char kOmniboxOnDeviceHeadSuggestionsDescription[] =
+ "Google head non personalized search suggestions provided by a compact on "
+ "device model for non-incognito. Turn off this feature if you have other "
+ "apps running which affects local file access (e.g. anti-virus software) "
+ "and are experiencing searchbox typing lags.";
+const char kOmniboxOnDeviceHeadSuggestionsIncognitoName[] =
+ "Omnibox on device head suggestions (incognito only)";
+const char kOmniboxOnDeviceHeadSuggestionsIncognitoDescription[] =
+ "Google head non personalized search suggestions provided by a compact on "
+ "device model for incognito. Turn off this feature if you have other "
+ "apps running which affects local file access (e.g. anti-virus software) "
+ "and are experiencing searchbox typing lags.";
+
const char kOmniboxRichAutocompletionName[] = "Omnibox Rich Autocompletion";
const char kOmniboxRichAutocompletionDescription[] =
"Allow autocompletion for titles and non-prefixes. I.e. suggestions whose "
