| commit | 78f7e557e192853df2cce30619ebd4a68ee7ae3e | [log] [tgz] |
|---|---|---|
| author | Robbie Gibson <[email protected]> | Tue Mar 26 11:40:33 2019 |
| committer | Commit Bot <[email protected]> | Tue Mar 26 11:40:33 2019 |
| tree | be149def760e75476a45a7b889cd7cc84d1edaec | |
| parent | 7eeae7b08f6c001990b4184ea3d46ed5c30cc66c [diff] |
🦁 Fix organization of ios omnibox popup files and build files Many of the protocols and files used in the omnibox popup were actually stored in the omnibox directory. This lead to dependency cycles, especially when trying to keep Showcase code from depending on too much on components code. To fix this, I moved - autocomplete_match_formatter - autocomplete_suggestion - truncating_attributed_label - image_retriever from omnibox/ to omnibox/popup/. All of these were only used in popup/, so it was easy to fix the dependencies. This also allowed the creation of a new popup_ui target that can be used in Showcase without bringing in too many dependencies. Bug: None Change-Id: I4aa69690f9d322d5105a26420e8992882204a3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532103 Commit-Queue: Robbie Gibson <[email protected]> Reviewed-by: Mark Cogan <[email protected]> Reviewed-by: Stepan Khapugin <[email protected]> Cr-Commit-Position: refs/heads/master@{#644258}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .