Google Git
Sign in
chromium / chromium / src / 7af0f13017807278976a94618bcf7da3322b066c
commit7af0f13017807278976a94618bcf7da3322b066c[log] [tgz]
authoredchin <[email protected]>Fri Jan 19 01:20:25 2018
committerCommit Bot <[email protected]>Fri Jan 19 01:20:25 2018
tree329c95f44ecf0d016b06ac0d1a286947d1888e77
parentd35abd616a8f88e34f37a28be800694ae741db51 [diff]
[ios] Refactor ExternalAppLauncherTabHelper

This CL achieves several objectives:

1) Removes the use of |rootViewController| to present UI.

2) Separates launching from the policy decider logic. The
tab helper holds the policy decider logic. The app launcher
coordinator does the actual app launching.

3) Better naming: "ExternalAppLauncher" was renamed to
"AppLauncher". It is more concise, and "external" did not
provide any value as there is no "internal app".

4) Better folder structure: the tab helper was pulled out
to it's own folder /chrome/browser/app_launcher. The app
launcher coordinator lives in /chrome/browser/ui/app_launcher.

5) Unit tests were added to the coordinator and tab helper.

Bug: 791792
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I53ab441db05b85211102df169a264f0fcf53195c
Reviewed-on: https://chromium-review.googlesource.com/837725
Commit-Queue: edchin <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#530375}
25 files changed
tree: 329c95f44ecf0d016b06ac0d1a286947d1888e77
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .