Google Git
Sign in
chromium / chromium / src / 7f15aade2680af123d7534206cfd53fd66c728ea
commit7f15aade2680af123d7534206cfd53fd66c728ea[log] [tgz]
authorJoe DeBlasio <[email protected]>Thu Aug 22 01:39:08 2019
committerCommit Bot <[email protected]>Thu Aug 22 01:39:08 2019
tree0d1155a0dc5ce98959a3950d95cb681bf2c63e1f
parent10a207e69c27b7b09e49e987391ab1180edacc42 [diff]
Ensure Safety Tips only open when tab is visible.

This CL prevents the Safety Tip bubble or infobar from activating when a
page is loaded in the background by adding a visibility check before
displaying and checking safety tip status when a tab becomes newly
visible. This results in potentially checking the reputation of a page
multiple times, but doing so is inexpensive at present. If future checks
are heavier, we may need to cache reputation results.

This CL also changes behavior of the escape key, which is now treated as
equivalent to other ways to close the bubble.

Bug: 994410
Change-Id: I27c4bb6839afb6e9e5188665aa89cd30437c75cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761221
Commit-Queue: Joe DeBlasio <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Cr-Commit-Position: refs/heads/master@{#689301}
5 files changed
tree: 0d1155a0dc5ce98959a3950d95cb681bf2c63e1f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .