| commit | 7ff0babd952398b7c5c0e3876344d1f94e55c20a | [log] [tgz] |
|---|---|---|
| author | Elly Fong-Jones <[email protected]> | Mon Apr 20 20:57:51 2020 |
| committer | Commit Bot <[email protected]> | Mon Apr 20 20:57:51 2020 |
| tree | 0115f7edb3ddee1709bbd278977345b0c29a662c | |
| parent | a40d4847e327aafc7caa0b0116e413b5e5f64f8f [diff] |
flags: rigorously define expiration milestone There are two competing definitions of expiration milestone: a) The last milestone in which a flag is present b) The first milestone in which a flag is not present The docs in //docs/flag_expiry.md and the code in //tools/flags implemented (b), but the block comment in flag-metadata.md described (a). Since that block comment has been much more widely read and relied upon than either of the other two sources, this change makes (a) the behavior everywhere. This will hopefully reduce confusion in client teams about where their flags have gone :) Bug: 1072433 Change-Id: I0f8fcbde2509b1bed05b98ac847c98595c74836f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155841 Reviewed-by: Alexei Svitkine <[email protected]> Reviewed-by: Nico Weber <[email protected]> Commit-Queue: Elly Fong-Jones <[email protected]> Cr-Commit-Position: refs/heads/master@{#760681}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.