| commit | 817c7d4a8f4f31acac2e444a5624c08a8b538aec | [log] [tgz] |
|---|---|---|
| author | Eddy Hsu <[email protected]> | Thu Jul 13 20:07:25 2023 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Jul 13 20:07:25 2023 |
| tree | 683683a652a1c469480d476278da5ff4d287c447 | |
| parent | 837230c6def5eae42a7f5eeb173d15f4af4aa29c [diff] [blame] |
Reland "[VoiceIsolation] Add new stream effect VoiceIsolation." This reverts commit 8525e454b007e742d1817b03fbe824a5f30d7aab. Reason for revert: The revert is caused by Kevin build failed. The latest image built for Kevin is on 15511 while the dependent change(crrev/c/4206140) is landed on 15514. Kevin is EOL in M116 and is replaced by jacuzzi for LKGM CL.(More context: b/290268385) Original change's description: > Revert "[VoiceIsolation] Add new stream effect VoiceIsolation." > > This reverts commit 6eac3ae3f0b40f0fdcc292b77549405dbfbfb402. > > Reason for revert: build break: https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-kevin-chrome/27478/overview > > Original change's description: > > [VoiceIsolation] Add new stream effect VoiceIsolation. > > > > New api introduced to provide the options to force turn on/off system > > voice isolation(NC) effect and check the platform availability. > > > > The control will be a tri-state composed of two bits(browser_controlled_{effect}, {effect}). > > !browser_controlled_{effect}: leave as platform default. > > browser_controlled_{effect} && {effect}: force enable platform {effect} > > browser_controlled_{effect} && !{effect}: force disable platform {effect} > > > > Design: https://docs.google.com/document/d/1a1zy_wYTgKhaPIAZ53lR8Y1RQzuzhND_kV7PLlP5WzE/edit?resourcekey=0-snrCqjLZrU8Bt9V0kW2hZA#heading=h.c0uts5ftkk58 > > > > > > Cq-Depend: chromium:4206140 > > BUG=b:218593870 > > TEST=build chrome, deploy to dut and verify > > > > Change-Id: Ifcc30a2c36c356b59734eb0972d502087f7870ee > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4225006 > > Commit-Queue: Eddy Hsu <[email protected]> > > Reviewed-by: Dale Curtis <[email protected]> > > Reviewed-by: Caitlin Fischer <[email protected]> > > Reviewed-by: Olga Sharonova <[email protected]> > > Reviewed-by: Yu-Hsuan Hsu <[email protected]> > > Reviewed-by: Sam Zackrisson <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1166113} > > BUG=b:218593870 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > > Change-Id: Ie46f2667cb1dd8d147d7946944ec6085409dcb3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4667948 > Owners-Override: Hayato Ito <[email protected]> > Reviewed-by: Hayato Ito <[email protected]> > Reviewed-by: Dale Curtis <[email protected]> > Reviewed-by: Caitlin Fischer <[email protected]> > Auto-Submit: Xiaoling Bao <[email protected]> > Commit-Queue: Hayato Ito <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1166330} BUG=b:218593870 Change-Id: I97fc4e99b9b7c5088af022bb517d960c159ebe05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4676142 Reviewed-by: Tomas Gunnarsson <[email protected]> Reviewed-by: Li-Yu Yu <[email protected]> Reviewed-by: Caitlin Fischer <[email protected]> Reviewed-by: Yu-Hsuan Hsu <[email protected]> Reviewed-by: Hayato Ito <[email protected]> Commit-Queue: Eddy Hsu <[email protected]> Reviewed-by: Dale Curtis <[email protected]> Reviewed-by: Sam Zackrisson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1170101}
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc index 56d078a..b1c8bac 100644 --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc
@@ -6918,6 +6918,11 @@ const char kShowForceRespectUiGainsToggleDescription[] = "Enable a setting toggle to force respect UI gains."; +const char kCrOSSystemVoiceIsolationOptionName[] = + "Enable the options of setting system voice isolation per stream"; +const char kCrOSSystemVoiceIsolationOptionDescription[] = + "Enable the options of setting system voice isolation per stream."; + const char kCrosPrivacyHubName[] = "Enable ChromeOS Privacy Hub"; const char kCrosPrivacyHubDescription[] = "Enables ChromeOS Privacy Hub.";