commit 22caa0f5861d1584fa3b9428f4e5bdefe9725bae
author Erik Chen <erikchen@chromium.org> Mon Oct 09 22:54:27 2017
committer Commit Bot <commit-bot@chromium.org> Mon Oct 09 22:54:27 2017
tree 211ab98c16c767f1a499264fad14cbe2e37c345a
parent a9045a82c946ecc735171ef79b84acf76b1c8fba

Revert "[Reland #1] Switch task manager to use the memory_instrumentation interface."

This reverts commit cbde21cc10818a0d9a2d4bf4c56900a37a3249d0.

Reason for revert: Causes ASAN test timeouts.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F34934%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FSitePerProcess__x2f_TaskManagerOOPIFBrowserTest.SubframeHistoryNavigation__x2f_0%2F0

Original change's description:
> [Reland #1] Switch task manager to use the memory_instrumentation interface.
> 
> The original CL caused a renderer hang for a macOS ASAN browser test. For an
> in-depth investigation, see
> https://bugs.chromium.org/p/chromium/issues/detail?id=771805. The root cause was two fold:
>   * A logic error in the original CL incorrectly caused memory details to be
>   refreshed when only the memory footprint needed to be refreshed. Fixed in this
>   reland.
>   * A logic error in the cocoa TaskManager caused memory details to always be
>   refreshed. Fixed in
>   https://chromium-review.googlesource.com/c/chromium/src/+/706197.
> 
> This CL also contains a minor optimization - the task manager will only ever
> queue a single memory dump at a time.
> 
> > The memory_instrumentation interface on the content_browser service exposes
> > cross-platform, consistent memory metrics that should also be used by the task
> > manager.
> >
> > This CL adds a new column to the task manager: Memory Footprint. See
> > https://docs.google.com/document/d/1PZyRzChnvkUNUB85Op46aqkFXuAGUJi751DJuB6O40g/edit#
> > for more details.
> >
> > Bug: 756276
> > Reviewed-on: https://chromium-review.googlesource.com/646047
> > Reviewed-by: Nick Carter <nick@chromium.org>
> > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > Commit-Queue: Erik Chen <erikchen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#506220}
> 
> Change-Id: I6fc43d064206bc614c52f84515f73dd98832f122
> Bug: 
> Reviewed-on: https://chromium-review.googlesource.com/706336
> Reviewed-by: Nick Carter <nick@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507483}

TBR=nick@chromium.org,erikchen@chromium.org

Change-Id: Ie811aff981e996d7f339845edc02c4bb1c4c8cd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/707782
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507519}