Simplify skia_opts target.
Remove some variables that are always empty.
Change-Id: I55a24915483033e221b9808a8fd2dbd64dc9d24b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892450
Reviewed-by: Brian Osman <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1047636}
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index d204ad22..b2298a7 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -739,7 +739,6 @@
deps = [ "//base" ]
if (current_cpu == "x86" || current_cpu == "x64") {
- sources = []
deps += [
":skia_opts_avx",
":skia_opts_hsw",
@@ -755,7 +754,6 @@
}
if (arm_version >= 7) {
- sources = []
if (arm_use_neon || arm_optionally_use_neon) {
# Root build config sets -mfpu=$arm_fpu, which we expect to be neon
# when running this.
@@ -764,24 +762,19 @@
cflags += [ "-mfpu=neon" ]
}
}
- } else {
- sources = []
}
} else if (current_cpu == "arm64") {
- sources = []
deps += [ ":skia_opts_crc32" ]
} else if (current_cpu == "mipsel") {
cflags += [ "-fomit-frame-pointer" ]
- sources = []
} else if (current_cpu == "mips64el") {
cflags += [ "-fomit-frame-pointer" ]
- sources = []
} else if (current_cpu == "ppc64") {
- sources = []
+ # Conditional and empty body needed to avoid assert() below.
} else if (current_cpu == "s390x") {
- sources = []
+ # Conditional and empty body needed to avoid assert() below.
} else if (current_cpu == "riscv64") {
- sources = []
+ # Conditional and empty body needed to avoid assert() below.
} else {
assert(false, "Unknown cpu target")
}
