| commit | 8f2cf7faca1b0170ff07735ad2a1931688a3269f | [log] [tgz] |
|---|---|---|
| author | Maksim Ivanov <[email protected]> | Mon Aug 31 16:39:38 2020 |
| committer | Commit Bot <[email protected]> | Mon Aug 31 16:39:38 2020 |
| tree | cdfc32ffa141ad2a52f4d5bccda0f7bee01dbb6d | |
| parent | 8aded5e3820d911a27727e83c2babaa82fabbac2 [diff] [blame] |
Fix use-after-move in //components/omnibox/browser/ Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4ea0a82440442e986e82a41206a0904223d2a858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382816 Reviewed-by: Justin Donnelly <[email protected]> Commit-Queue: Maksim Ivanov <[email protected]> Cr-Commit-Position: refs/heads/master@{#803140}
diff --git a/components/omnibox/browser/clipboard_provider.cc b/components/omnibox/browser/clipboard_provider.cc index 25b3b18..467df170 100644 --- a/components/omnibox/browser/clipboard_provider.cc +++ b/components/omnibox/browser/clipboard_provider.cc
@@ -552,8 +552,10 @@ void ClipboardProvider::OnReceiveImage( ClipboardImageMatchCallback callback, base::Optional<gfx::Image> optional_image) { - if (!optional_image) + if (!optional_image) { std::move(callback).Run(base::nullopt); + return; + } gfx::ImageSkia image_skia = *optional_image.value().ToImageSkia(); image_skia.MakeThreadSafe(); base::ThreadPool::PostTaskAndReplyWithResult(