Google Git
Sign in
chromium / chromium / src / 91b50f5c6407e36e9a0d82ae4bddadb91b8dd0d4
commit91b50f5c6407e36e9a0d82ae4bddadb91b8dd0d4[log] [tgz]
authorEvan Stade <[email protected]>Mon Feb 14 17:09:57 2022
committerChromium LUCI CQ <[email protected]>Mon Feb 14 17:09:57 2022
treee3d71bc63e04ddb68e595a15ba8d5e2642db996e
parent4356cb872b647fb7e1ab74bdb42703a19e421a73 [diff]
ChromeOS: Update icons in chrome://downloads

Update ChromeOS's IconLoader implementation to pull the icons from
ash's file_icon_util, which is already in use for many other UI
surfaces.

IconManager and IconLoader are old and crufty in their ownership
model, and designed around the assumption that loading icons will
be a slow operation involving disk I/O, but for Chrome OS this
isn't true. This CL does not attempt to refactor IconManager and
IconLoader more than is necessary, but still substantially
simplifies the CrOS code and allows us to remove a few old raster
assets.

Bug: 1295918
Change-Id: I936424214ef0ad0f0c322d28d2f8d25efd731cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3451040
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#970669}
36 files changed
tree: e3d71bc63e04ddb68e595a15ba8d5e2642db996e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.