Google Git
Sign in
chromium / chromium / src / 9c8057d4229e010e97efc03e6e20efff3ee95690
commit9c8057d4229e010e97efc03e6e20efff3ee95690[log] [tgz]
authorReilly Grant <[email protected]>Sat Mar 31 00:40:57 2018
committerCommit Bot <[email protected]>Sat Mar 31 00:40:57 2018
tree586a246cba5717e2039744242ba7cfd1a7a9a489
parent0a4382cf0466f8ae431ac4af3e1fe24686be53e8 [diff]
Block the WebUSB chooser when the guard permission is 'block'

This change adds logic to the WebUSB device chooser (on desktop) so that
when the WebUSB guard permission is set to 'block' the chooser will be
automatically dismissed as if the user had not selected any devices.

This matches the behavior of the Web Bluetooth chooser and its guard
permission.

To test this change the WebUsbChooserService class has been refactored
so that its shared logic can be reused by tests. A follow-up patch will
make WebUsbChooserServiceAndroid also inherit from this class.

Bug: 771703
Change-Id: I3f2cc6e96a9ebf039bc15d396d16eb4a0766007e
Reviewed-on: https://chromium-review.googlesource.com/987327
Commit-Queue: Reilly Grant <[email protected]>
Reviewed-by: Jun Cai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#547338}
7 files changed
tree: 586a246cba5717e2039744242ba7cfd1a7a9a489
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. webrunner/
  55. .clang-format
  56. .eslintrc.js
  57. .git-blame-ignore-revs
  58. .gitattributes
  59. .gitignore
  60. .gn
  61. .vpython
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .