Replace content::NavigationState public interface with some bools
Instead of exposing NavigationState, observers get two additional
values in Did{Start,Commit}ProvisionalLoad callbacks.
This will allow us to remove NavigationState entirely to simplify
navigation tracking between blink and content. As a first step,
we can stop tracking transition type.
[email protected],[email protected],[email protected],[email protected]
Bug: 855189
Change-Id: I6344ca4716121af9513c9bc672e5e9b28d49f055
Reviewed-on: https://chromium-review.googlesource.com/1226198
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592204}diff --git a/content/renderer/navigation_state_impl.h b/content/renderer/navigation_state_impl.h
index 9b3628b9..20e66fa9 100644
--- a/content/renderer/navigation_state_impl.h
+++ b/content/renderer/navigation_state_impl.h
@@ -28,10 +28,15 @@
static NavigationStateImpl* CreateContentInitiated();
- // NavigationState implementation.
- ui::PageTransition GetTransitionType() override;
- bool WasWithinSameDocument() override;
- bool IsContentInitiated() override;
+ // Contains the transition type that the browser specified when it
+ // initiated the load.
+ ui::PageTransition GetTransitionType();
+
+ // True iff the frame's navigation was within the same document.
+ bool WasWithinSameDocument();
+
+ // True if this navigation was not initiated via WebFrame::LoadRequest.
+ bool IsContentInitiated();
const CommonNavigationParams& common_params() const { return common_params_; }
const RequestNavigationParams& request_params() const {
