Google Git
Sign in
chromium / chromium / src / dab534357763fbe122191d6c7f749816e2c08696
commitdab534357763fbe122191d6c7f749816e2c08696[log] [tgz]
authorMikel Astiz <[email protected]>Mon Jul 16 07:14:05 2018
committerCommit Bot <[email protected]>Mon Jul 16 07:14:05 2018
treecc4a65ca0c4c3f928629cb8e44d45679e9b57250
parentb480f8867d5bfa89d9698c92a710ee53b2513dc8 [diff]
Revert "Snaps after scrollbar clicking."

This reverts commit e98df9c6e2269035a9abb23ca8fd8dc906ad3d38.

Reason for revert: suspect for webkit_layout_tests consistently
failing, e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/81791

Original change's description:
> Snaps after scrollbar clicking.
> 
> After user clicking on the scrollbar's track or arrows, we should snap
> to the closest snap position of the container. This is done by simply
> moving SnapAfterScrollbarDragging() from
> ScrollableArea::MouseReleasedScrollbar() up to Scrollbar::MouseUp().
> 
> This patch also rewrites the previous
> snaps-after-scrollbar-dragging.html test using the gesture-util.js, and
> adds the new clicking tests to it as well.
> 
> Bug: 860768
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I75267c3fc0917ecf5c14673a1eb480a047d03824
> Reviewed-on: https://chromium-review.googlesource.com/1127153
> Commit-Queue: Sandra Sun <[email protected]>
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Majid Valipour <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#575191}

[email protected],[email protected],[email protected]

Change-Id: Iab3c3c489bda0fc6b150ba0e0a5bde8de9721798
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860768
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1138013
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#575202}
10 files changed
tree: cc4a65ca0c4c3f928629cb8e44d45679e9b57250
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .