Standardize feed android resources
Note: this is a slightly modified reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1956275.
The only difference is adding SuppressWarnings for Validators.java,
which was prompted due a change in errorprone.
- Restructure to match chrome/browser/java/res
- Replace strings with references to existing .grd strings
- I kept Piet resources separate, since piet may eventually be moved into
a different library.
- Move feed/library sources into chrome_java
Strings changed:
snackbar_fetch_no_new_suggestions -> ntp_suggestions_fetch_no_new_suggestions
snackbar_fetch_failed -> ntp_suggestions_fetch_failed
snackbar_default_action -> undo
It looks like chromium's strings are translated to more languages, so
this might provide better localization. Some of these strings are
translated differently between feed and zine.
[email protected],[email protected],[email protected],[email protected]
Change-Id: I2a14b0c4b4b60c7ab5b45ead0ec75b09233f4d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017243
Reviewed-by: Dan H <[email protected]>
Commit-Queue: Dan H <[email protected]>
Cr-Commit-Position: refs/heads/master@{#734726}
diff --git a/components/ntp_snippets_strings.grdp b/components/ntp_snippets_strings.grdp
index 6f3e479..d755fd1 100644
--- a/components/ntp_snippets_strings.grdp
+++ b/components/ntp_snippets_strings.grdp
@@ -35,19 +35,7 @@
</message>
</if>
- <if expr="use_titlecase">
- <message name="IDS_NTP_SUGGESTIONS_SECTION_HEADER" desc="Header of the suggested content section, which is a list of suggested content displayed as cards on the New Tab Page. This will replace a string 'Articles for You', which was used when the suggested content was just news articles. ">
- For You
- </message>
- </if>
-
- <if expr="not use_titlecase">
- <message name="IDS_NTP_SUGGESTIONS_SECTION_HEADER" desc="Header of the suggested content section, which is a list of suggested content displayed as cards on the New Tab Page. This will replace a string 'Articles for You', which was used when the suggested content was just news articles. " formatter_data="android_java">
- For you
- </message>
- </if>
-
- <message name="IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_EMPTY" desc="On the New Tab Page, text of the card explaining to the user that they can expect to see suggested articles in this area in the future.">
+ <message name="IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_EMPTY" desc="On the New Tab Page, text of the card explaining to the user that they can expect to see suggested articles in this area in the future." formatter_data="android_java">
Your suggested articles appear here
</message>
