Google Git
Sign in
chromium / chromium / src / b6a01f7921e37e8e5642d087faee79f5dc17ee43
commitb6a01f7921e37e8e5642d087faee79f5dc17ee43[log] [tgz]
authorGregory Chatzinoff <[email protected]>Wed Sep 20 20:06:39 2017
committerCommit Bot <[email protected]>Wed Sep 20 20:06:39 2017
tree58ce726bbfeca125625102ae5f1e4bf171d35ddf
parent1e5c67abd6325c2c316fa9a9430b85079174f0d6 [diff]
Remove use of parent view from PageInfoVC.

The PageInfoViewController class used to add a subview directly to its
parent view. This CL moves that logic to the presentation provider, so
that the parent view does not need to be passed to the Page Info
component.

Bug: none
Change-Id: I150cae3928adebcb378c7d7ed968a59885ca9401
Reviewed-on: https://chromium-review.googlesource.com/673873
Commit-Queue: Gregory Chatzinoff <[email protected]>
Reviewed-by: Rohit Rao (ping after 24h) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#503230}
5 files changed
tree: 58ce726bbfeca125625102ae5f1e4bf171d35ddf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .