Google Git
Sign in
chromium / chromium / src / b9816d5ca93a5aba3e8cc686e19770692c1447e9
commitb9816d5ca93a5aba3e8cc686e19770692c1447e9[log] [tgz]
authorRegan Hsu <[email protected]>Wed May 26 15:03:48 2021
committerChromium LUCI CQ <[email protected]>Wed May 26 15:03:48 2021
treea6b448ee696ec9385de248606ab22ec2814ac8c4
parent41047bd1138ef22db34de3f47a4fc3c8a6f583e4 [diff]
[CrOS Cellular] Create feature flag to forbid use of Attach APN.

Currently, we have a feature flag kCellularUseAttachApn, which is
enabled via board-overlays and setting the command line argument [1].

However, if the feature misbehaves, the server-side field trial config
is unable to turn off the feature remotely because command line
arguments take precedence over finch configs.

A new feature flag kCellularForbidAttachApn should be added so that
finch can remotely disable the Attach APN feature. If
kCellularForbidAttachApn is enabled, the value of kCellularUseAttachApn
should be ignored.

[1] https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2898018


Bug: 1213103
Change-Id: Iac334c478bfda47b05b6ee2e89daa03cd980eca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2916479
Commit-Queue: Regan Hsu <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#886732}
9 files changed
tree: a6b448ee696ec9385de248606ab22ec2814ac8c4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.