commit | bbdfbcdc73dee2155b1e1d51e2ae82dab21880bd | [log] [tgz] |
---|---|---|
author | Yoichi Osato <[email protected]> | Mon Dec 12 16:50:35 2022 |
committer | Chromium LUCI CQ <[email protected]> | Mon Dec 12 16:50:35 2022 |
tree | 699022aa34c8cafc9f3106a3b74b2b360a5cc89d | |
parent | 447a605b296a7059e85fe61b6ef94840845f5a97 [diff] |
Sanitize NetworkServiceTestHelper instantiation. This makes NetworkServiceTestHelper instantiation better: 1. Unify the instantiation condition to the class 2. Make sure there is up to one instance in the utility process of the network service. 3. Simplify caller by returning a callback. Bug: 1377734 Change-Id: Ib5349f548a0fd932e14f5fd5e4b066c4f8ace786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3970337 Reviewed-by: John Abd-El-Malek <[email protected]> Reviewed-by: Yaron Friedman <[email protected]> Reviewed-by: Eric Seckler <[email protected]> Auto-Submit: Yoichi Osato <[email protected]> Reviewed-by: Ben Wells <[email protected]> Reviewed-by: danakj <[email protected]> Commit-Queue: Ben Wells <[email protected]> Cr-Commit-Position: refs/heads/main@{#1081809}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.