Google Git
Sign in
chromium / chromium / src / be9cafe10c1118044855a80f0bb2d0b2f222fe44
commitbe9cafe10c1118044855a80f0bb2d0b2f222fe44[log] [tgz]
authorChristopher Thompson <[email protected]>Wed Feb 05 04:46:11 2020
committerCommit Bot <[email protected]>Wed Feb 05 04:46:11 2020
treed5ff4e299a0157616bdd8adf9d036bd9e525a9c5
parentf169f08face518cea4dfa9cba496ca4c13151a51 [diff]
Plumb control config into network service

This exposes the control config for legacy TLS errors to the network
stack. This is loosely based on the same design that the CRLSet
component installer uses:
1. Installer passes to network service via Mojo
2. Network service keeps a LegacyTLSConfigDistributor which tracks
   observers that care about the config
3. SSLConfigServiceMojo registers an observer to get the latest
   config
4. SSLConfigService exposes an interface to check
   ShouldSuppressLegacyTLSWarning()

This change also moves the tls_deprecation_config.proto into the network
service, and adds a ref counted wrapper around it (so that the
LegacyTLSConfigDistributor can pass them to the observers without
lifetime issues).

This currently duplicates the control config set (there is a copy in the
browser and a copy in the network service). A followup CL will address
this.

The new cert error is introduced in https://crrev.com/c/1894616.
The new interstitial is introduced in https://crrev.com/c/1940707.

Bug: 896013, 1039756
Change-Id: I31fee71c292ffe8b592d3c6f47c3352ed4475892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906779
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Christopher Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#738435}
38 files changed
tree: d5ff4e299a0157616bdd8adf9d036bd9e525a9c5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .