| commit | bff3a165135ddfb9cc4dad89c0df0d73c25a0952 | [log] [tgz] |
|---|---|---|
| author | Eric Lawrence <[email protected]> | Tue May 23 04:12:03 2023 |
| committer | Chromium LUCI CQ <[email protected]> | Tue May 23 04:12:03 2023 |
| tree | 9ed656cef21a6895ecee2a227746222482117879 | |
| parent | af570b4f83504d46a4eaba70b98cd7d133d3db33 [diff] |
Directly launch Native Host executables on Windows
Previously, launching an extension's native host executable on Windows
would launch cmd.exe, setting the input and output pipes to Named Pipes
used to share JSON messages between the extension and the Host app.
While this worked in most cases, it would fail in cases where:
1) the system disabled access to cmd.exe,
2) cmd.exe was configured to always elevate,
3) COMSPEC was pointed at something other than cmd.exe, or
4) a special character (e.g. &) was in the path to the Native
Host program.
This CL changes the calling pattern for the common case where the Native
Host manifest points at an executable. In such cases, Chrome will now
directly launch the executable and pass file streams to its stdin and
stdout, avoiding the invocation of cmd.exe altogether.
For legacy compatibility (e.g. a Native Host can be implemented via a
python script launched by a batch file), the old path using cmd.exe
remains for use when the Native Host target is not an executable.
This change was previously landed and backed out due to compatibility
issues with some Native Hosts. It is now behind an off-by-default
feature flag to enable experimentation and evangelism.
BUG=1445763,335558,387233,387228
Change-Id: I6906f708caeb47a3c3c3248b155b9610426aadb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4522048
Reviewed-by: Will Harris <[email protected]>
Commit-Queue: Eric Lawrence <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1147656}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.