commit c49b346d6fdeff7226c780615e599192a65ba9b6
author Lloyd Pique <lpique@chromium.org> Fri Nov 20 02:14:23 2020
committer Commit Bot <commit-bot@chromium.org> Fri Nov 20 02:14:23 2020
tree b2750456f6ff0cd5e4f14c7607630f232f4b0d16
parent 64a654d03e6e97a70f36cbe68260547090560f4e

Register for overlays when handling Android payments

Test: Test Payment app shows the Play Store overlay
Bug: b:172592701

Change-Id: I540c4c91225aad0f3cca1c3bb66024a84cfa3deb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519891
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Lloyd Pique <lpique@chromium.org>
Auto-Submit: Lloyd Pique <lpique@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829481}

components/payments/content/android_app_communication_unittest.cc

diff --git a/components/payments/content/android_app_communication_unittest.cc b/components/payments/content/android_app_communication_unittest.cc
index 552e46b3..ba3ad57 100644
--- a/components/payments/content/android_app_communication_unittest.cc
+++ b/components/payments/content/android_app_communication_unittest.cc
@@ -14,6 +14,8 @@
 #include "base/optional.h"
 #include "components/payments/content/android_app_communication_test_support.h"
 #include "components/payments/core/android_app_description.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/test_web_contents_factory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
@@ -45,7 +47,9 @@
 class AndroidAppCommunicationTest : public testing::Test {
  public:
   AndroidAppCommunicationTest()
-      : support_(AndroidAppCommunicationTestSupport::Create()) {}
+      : support_(AndroidAppCommunicationTestSupport::Create()),
+        web_contents_(
+            web_contents_factory_.CreateWebContents(support_->context())) {}
   ~AndroidAppCommunicationTest() override = default;
 
   AndroidAppCommunicationTest(const AndroidAppCommunicationTest& other) =
@@ -77,6 +81,8 @@
   }
 
   std::unique_ptr<AndroidAppCommunicationTestSupport> support_;
+  content::TestWebContentsFactory web_contents_factory_;
+  content::WebContents* web_contents_;
   base::Optional<std::string> error_;
   std::vector<std::unique_ptr<AndroidAppDescription>> apps_;
   bool is_ready_to_pay_ = false;
@@ -466,6 +472,7 @@
       "com.example.app", "com.example.app.Activity", stringified_method_data,
       GURL("https://top-level-origin.com"),
       GURL("https://payment-request-origin.com"), "payment-request-id",
+      web_contents_,
       base::BindOnce(&AndroidAppCommunicationTest::OnPaymentAppResponse,
                      base::Unretained(this)));
 
@@ -490,6 +497,7 @@
       "com.example.app", "com.example.app.Activity", stringified_method_data,
       GURL("https://top-level-origin.com"),
       GURL("https://payment-request-origin.com"), "payment-request-id",
+      web_contents_,
       base::BindOnce(&AndroidAppCommunicationTest::OnPaymentAppResponse,
                      base::Unretained(this)));
 
@@ -522,6 +530,7 @@
       "com.example.app", "com.example.app.Activity", stringified_method_data,
       GURL("https://top-level-origin.com"),
       GURL("https://payment-request-origin.com"), "payment-request-id",
+      web_contents_,
       base::BindOnce(&AndroidAppCommunicationTest::OnPaymentAppResponse,
                      base::Unretained(this)));
 
@@ -557,6 +566,7 @@
       "com.example.app", "com.example.app.Activity", stringified_method_data,
       GURL("https://top-level-origin.com"),
       GURL("https://payment-request-origin.com"), "payment-request-id",
+      web_contents_,
       base::BindOnce(&AndroidAppCommunicationTest::OnPaymentAppResponse,
                      base::Unretained(this)));
 
@@ -589,6 +599,7 @@
       "com.example.app", "com.example.app.Activity", stringified_method_data,
       GURL("https://top-level-origin.com"),
       GURL("https://payment-request-origin.com"), "payment-request-id",
+      web_contents_,
       base::BindOnce(&AndroidAppCommunicationTest::OnPaymentAppResponse,
                      base::Unretained(this)));
 
@@ -621,6 +632,7 @@
       "com.example.app", "com.example.app.Activity", stringified_method_data,
       GURL("https://top-level-origin.com"),
       GURL("https://payment-request-origin.com"), "payment-request-id",
+      web_contents_,
       base::BindOnce(&AndroidAppCommunicationTest::OnPaymentAppResponse,
                      base::Unretained(this)));