[VC]: add vc flags, connect to camera HAL server
This CL also removes some unused flag definitions.
This is a reland of https://crrev.com/c/3949174 with fixes to the
unit tests that were causing flakes. These fixes include a race
condition in ServerConnectionError where after disconnecting the
server it could try and reconnect before the disconnect handler
had been executed on the other side. Added in an observer to get
a signal when the handler had been executed and only reconnect
after that.
BUG=b:251337330
TEST=deploy to DUT, toggle flag on and off, see mojo call in logs
Change-Id: I300d2e6a997c111188eab41c457b06c705ce49e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3955002
Commit-Queue: Jim Pollock <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Ricky Liang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1059794}
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index eb2bd1e..ac67864 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -3127,6 +3127,16 @@
const char kVCBackgroundBlurDescription[] =
"Enables background blur feature for video conferencing on chromebooks.";
+const char kVCBackgroundReplaceName[] = "Enable vc background replacement";
+const char kVCBackgroundReplaceDescription[] =
+ "Enables background replacement feature for video conferencing on "
+ "chromebooks. THIS WILL OVERRIDE BACKGROUND BLUR.";
+
+const char kVCPortraitRelightingName[] = "Enable vc portrait relighting";
+const char kVCPortraitRelightingDescription[] =
+ "Enables portrait relighting feature for video conferencing on "
+ "chromebooks. THIS WILL OVERRIDE BACKGROUND BLUR & REPLACE.";
+
const char kV8VmFutureName[] = "Future V8 VM features";
const char kV8VmFutureDescription[] =
"This enables upcoming and experimental V8 VM features. "