Google Git
Sign in
chromium / chromium / src / cb31a472c3dac146994fcec4a94d2f554b314fef
commitcb31a472c3dac146994fcec4a94d2f554b314fef[log] [tgz]
authorColin Blundell <[email protected]>Fri Jan 31 12:40:44 2020
committerCommit Bot <[email protected]>Fri Jan 31 12:40:44 2020
tree1de8f5c2b7d7bd9862671bd120d291e27a161755
parent82e3c2330171d877921695b09e19592ddbd252d9 [diff]
[SSL] Componentize SSLErrorHandler unittest

Follows the componentization of the production class. One note is that
there are multiple independent test classes in the unittest file that
all construct TestSSLErrorHandler instances. As the manual construction
of a CaptivePortalService instance is somewhat cumbersome, we did it
only in the tests that actually need it; in the other tests we simply
pass nullptr. This is analogous to the how the tests are handling the
NetworkTimeTracker parameter of TestSSLErrorHandler. Finally, the test
is augmented to account for the fact that on Chromecast, where the test
now runs as part of components_unittests, captive portal detection is
not enabled.

Bug: 1030692
Change-Id: If9292ebbf26437ef85f42f248468325f6d1795f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030524
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#737293}
4 files changed
tree: 1de8f5c2b7d7bd9862671bd120d291e27a161755
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .