| commit | d02a48c7413aead7c37cdefe9b6979a15b1605de | [log] [tgz] |
|---|---|---|
| author | Zhongyi Shi <[email protected]> | Tue Aug 27 21:03:58 2019 |
| committer | Commit Bot <[email protected]> | Tue Aug 27 21:03:58 2019 |
| tree | b70461de1813aeb20ff6ab0a109a4983accb1509 | |
| parent | 918a3654e2f0b1f71c77459a01c1d26f4e9c49a5 [diff] [blame] |
Turn off goaway_sessions_on_ip_change explicitly in iOS migration tests. http://crbug.com/c/1769725 forces check the caller does not set options to handle ip address change and connection migration simultaneously. iOS however enables "goaway_sessions_on_ip_change" be default, which caused the migration option setting test fails. Bug: 998156 Change-Id: I8968a257c555b165ecca3aa60138366960c00b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773343 Auto-Submit: Zhongyi Shi <[email protected]> Reviewed-by: Lily Chen <[email protected]> Reviewed-by: Ryan Hamilton <[email protected]> Commit-Queue: Ryan Hamilton <[email protected]> Cr-Commit-Position: refs/heads/master@{#690878}
diff --git a/components/cronet/url_request_context_config_unittest.cc b/components/cronet/url_request_context_config_unittest.cc index aa3a9ea0..a924e4d 100644 --- a/components/cronet/url_request_context_config_unittest.cc +++ b/components/cronet/url_request_context_config_unittest.cc
@@ -659,7 +659,10 @@ // User-Agent request header field. "fake agent", // JSON encoded experimental options. + // Explicitly turn off "goaway_sessions_on_ip_change" which is default + // enabled on iOS but cannot be simultaneously set with migration option. "{\"QUIC\":{\"migrate_sessions_on_network_change_v2\":true," + "\"goaway_sessions_on_ip_change\":false," "\"migrate_sessions_early_v2\":true," "\"retry_on_alternate_network_before_handshake\":true," "\"migrate_idle_sessions\":true,"