Google Git
Sign in
chromium / chromium / src / d27b4a8038e27c816a16c788a4a749ae7a76ed5e
commitd27b4a8038e27c816a16c788a4a749ae7a76ed5e[log] [tgz]
authorMike West <[email protected]>Fri Jul 13 09:53:38 2018
committerCommit Bot <[email protected]>Fri Jul 13 09:53:38 2018
tree7e6c0057370116a2885be1af22a4d70a2c62a8a8
parentf8b7b43d60f590eba54721bde22a485dfe21716d [diff]
Revert "Changed committed-interstitials flag from switch to feature."

This reverts commit 49040ae795592d3b0c6a5b03533565caeb9ae266.

Reason for revert: 

Findit (https://goo.gl/kROfz5) identified this CL at revision 574621 as the culprit
for introducing flakiness in the tests as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDkwNDBhZTc5NTU5MmQzYjBjNmE1YjAzNTMzNTY1Y2FlYjlhZTI2Ngw

Original change's description:
> Changed committed-interstitials flag from switch to feature.
> 
> Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
> base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
> doing separate rampups for each kind of committed interstitial. Switch was
> changed to Feature so that it can be enabled via variations.
> 
> Bug: 755632
> Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
> Reviewed-on: https://chromium-review.googlesource.com/1118975
> Commit-Queue: Carlos IL <[email protected]>
> Reviewed-by: Jialiu Lin <[email protected]>
> Reviewed-by: Maksim Ivanov <[email protected]>
> Reviewed-by: Emily Stark <[email protected]>
> Reviewed-by: Giovanni Ortuño Urquidi <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#574621}

[email protected],[email protected],[email protected],[email protected],[email protected]

Change-Id: If9f9b15c8e3654dbd011104dfa469943bcd66e0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 755632, 863272
Reviewed-on: https://chromium-review.googlesource.com/1136351
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#574870}
21 files changed
tree: 7e6c0057370116a2885be1af22a4d70a2c62a8a8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .