[PDF OCR] Use the same verb, "convert", in PDF OCR strings
As suggested by the UX writer, notification messages associating
"converted text" need to use the same verb, "context". Also, the tag,
`translateable="false"` has been removed as the strings are reviewed.
AX-Relnotes: n/a.
Bug: 1393069
Change-Id: I3cb746915fd2c6d09986f0ad3586bbb3516ab95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596259
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Kyungjun Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1155744}
diff --git a/components/pdf_strings.grdp b/components/pdf_strings.grdp
index bd96dc3..f6f9f293 100644
--- a/components/pdf_strings.grdp
+++ b/components/pdf_strings.grdp
@@ -344,24 +344,23 @@
</message>
</if>
<if expr="enable_screen_ai_service">
- <!-- TODO(crbug.com/1393069): Remove translateable tags when strings are approved. -->
- <message name="IDS_PDF_OCR_FEATURE_ALERT" is_accessibility_with_no_ui="true" translateable="false" desc="Notification of the PDF OCR feature when the user encounters an inaccessible PDF.">
+ <message name="IDS_PDF_OCR_FEATURE_ALERT" is_accessibility_with_no_ui="true" desc="Notification of the PDF OCR feature when the user encounters an inaccessible PDF.">
Press search plus m and convert image to text in the context menu
</message>
- <message name="IDS_PDF_OCR_IN_PROGRESS" is_accessibility_with_no_ui="true" translateable="false" desc="Notification to inform the user that OCR is in progress.">
+ <message name="IDS_PDF_OCR_IN_PROGRESS" is_accessibility_with_no_ui="true" desc="Notification to inform the user that OCR is in progress.">
Image is being analyzed
</message>
- <message name="IDS_PDF_OCR_COMPLETED" is_accessibility_with_no_ui="true" translateable="false" desc="Notification to inform the user that OCR is completed.">
+ <message name="IDS_PDF_OCR_COMPLETED" is_accessibility_with_no_ui="true" desc="Notification to inform the user that OCR is completed.">
Image converted to text
</message>
- <message name="IDS_PDF_OCR_NO_RESULT" is_accessibility_with_no_ui="true" translateable="false" desc="Notification to inform the user that no text was converted by OCR from images.">
+ <message name="IDS_PDF_OCR_NO_RESULT" is_accessibility_with_no_ui="true" desc="Notification to inform the user that no text was converted by OCR from images.">
No text converted from images
</message>
- <message name="IDS_PDF_OCR_RESULT_BEGIN" is_accessibility_with_no_ui="true" translateable="false" desc="Notification to inform the user of the beginning of OCR results.">
- Start of extracted text
+ <message name="IDS_PDF_OCR_RESULT_BEGIN" is_accessibility_with_no_ui="true" desc="Notification to inform the user of the beginning of OCR results.">
+ Start of converted text
</message>
- <message name="IDS_PDF_OCR_RESULT_END" is_accessibility_with_no_ui="true" translateable="false" desc="Notification to inform the user of the end of OCR results.">
- End of extracted text
+ <message name="IDS_PDF_OCR_RESULT_END" is_accessibility_with_no_ui="true" desc="Notification to inform the user of the end of OCR results.">
+ End of converted text
</message>
</if>
</grit-part>
diff --git a/components/services/screen_ai/proto/visual_annotator_proto_convertor_unittest.cc b/components/services/screen_ai/proto/visual_annotator_proto_convertor_unittest.cc
index e8b2a960..0aa1784 100644
--- a/components/services/screen_ai/proto/visual_annotator_proto_convertor_unittest.cc
+++ b/components/services/screen_ai/proto/visual_annotator_proto_convertor_unittest.cc
@@ -117,7 +117,7 @@
"AXTreeUpdate: root id -2\n"
"id=-2 region child_ids=-3,-4,-6 (0, 0)-(800, 900) "
"is_page_breaking_object=true\n"
- " id=-3 status name=Start of extracted text name_from=attribute"
+ " id=-3 status name=Start of converted text name_from=attribute"
" (0, 0)-(1, 1)\n"
" id=-4 staticText name=Hello world child_ids=-5 "
"offset_container_id=-2 (100, 100)-(500, 20) "
@@ -125,7 +125,7 @@
" id=-5 inlineTextBox name=Hello world (100, 100)-(500, 20) "
"background_color=&C350 color=&61A8 text_direction=rtl language=en "
"word_starts=0,6 word_ends=6,11\n"
- " id=-6 status name=End of extracted text name_from=attribute"
+ " id=-6 status name=End of converted text name_from=attribute"
" (800, 900)-(1, 1)\n");
EXPECT_EQ(expected_update, update.ToString());
}
