commit d9e4cb77324a3d4e0dfd6b599ce34e1224fdedb6
author Wez <wez@chromium.org> Wed Jan 09 03:07:03 2019
committer Commit Bot <commit-bot@chromium.org> Wed Jan 09 03:07:03 2019
tree 45847d613b7866bda7dcbf944bda283331ad805f
parent 4eb3b6e49aa880be6e71504a56719a778be26e82

Apply a default timeout to RunLoop::Run() calls on test main threads.

Sheriffs: This change is intended to expose tests which Run() for
an excessive amount of time. Please consider disabling tests which
hit the new Run() timeouts, rather than reverting this CL.

We add RunLoop::ScopedRunTimeoutForTest, which configures the calling
thread with a timeout, and optional callback, to apply to all Run()
calls made while it is in-scope. If a Run() is not Quit() by the caller
within the specified timeout then the loop is implicitly quit, and the
optional callback is run, if provided.

ScopedTaskEnvironment now applies a default ScopedRunTimeoutForTest set
to invoke LOG(FATAL) if any Run() on the test's main thread runs for
more than TestTimeouts::action_max_timeout().

Bug: 918724
Change-Id: I080b78e193202da0c9e3deee3a201ef1619cfd37
Reviewed-on: https://chromium-review.googlesource.com/c/1319344
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621022}