Google Git
Sign in
chromium / chromium / src / dd489d36d6c3eec79f55b9e29ad212a0cda5f4d2
commitdd489d36d6c3eec79f55b9e29ad212a0cda5f4d2[log] [tgz]
authorNazerke <[email protected]>Mon Feb 24 11:38:34 2020
committerCommit Bot <[email protected]>Mon Feb 24 11:38:34 2020
tree4599220685d19e76837d9383796e722424abe6c6
parent2a0239a8e66483fc725c936ce9b90f20396dbe16 [diff]
[iOS][coordinator] Modernize Omnibox Popup Coordinator.

This CL modernizes the OmniboxPopupCoordinator
 - to use |browser| in the initializer,
 - to remove the public property for  dispatcher, webstatelist and
browserstate,
 - to use self.browser to get browserstate, webstatelist and dispatcher
values.

This CL includes migration to ChromeCoordinator as a superclass.

Bug: 1029346, 1048423
Change-Id: Id99b8197d23cbb9d0b16e9a35b096a9b91213562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068598
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Nazerke Kalidolda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#743899}
5 files changed
tree: 4599220685d19e76837d9383796e722424abe6c6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .