commit | e02299a9f0fad3a2115e5d74fd6f4195d41dd3d1 | [log] [tgz] |
---|---|---|
author | Lei Zhang <[email protected]> | Mon Apr 26 23:12:24 2021 |
committer | Chromium LUCI CQ <[email protected]> | Mon Apr 26 23:12:24 2021 |
tree | 4b3c1822121359fb71a4a6b2300c73273336baf1 | |
parent | 72c848cf30df086332ac1d6577cbdaa9c61524b1 [diff] [blame] |
Do IWYU for base/strings/stringprintf.h. Files that use base::StringPrintf() and StringPrintV() should include stringprintf.h. Find the files that do not using this command: git grep -l 'base::StringPrint[fV]' | \ xargs grep -L '^#include "base/strings/stringprintf.h"$' | \ grep -E '(cc|mm)$' and add the include to those files. Then do a similar check for base::StringAppend. Change-Id: Ia736e7d64eeb13dc7aff72944ebe00f6931ed584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2849391 Reviewed-by: Peter Boström <[email protected]> Commit-Queue: Lei Zhang <[email protected]> Owners-Override: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/master@{#876342}
diff --git a/components/visitedlink/test/visitedlink_unittest.cc b/components/visitedlink/test/visitedlink_unittest.cc index 007904eb..e2e0527fa 100644 --- a/components/visitedlink/test/visitedlink_unittest.cc +++ b/components/visitedlink/test/visitedlink_unittest.cc
@@ -20,6 +20,7 @@ #include "base/run_loop.h" #include "base/single_thread_task_runner.h" #include "base/strings/string_util.h" +#include "base/strings/stringprintf.h" #include "base/threading/thread_task_runner_handle.h" #include "base/time/time.h" #include "base/timer/mock_timer.h"