check_network_annotations.py: update compile_targets
compile_targets only contains `traffic_annotation_proto' right now, so
this presubmit check is not running on the majority of CLs. Change it
back to `shipped_binaries', so it runs again.
Also, define `shipped_binaries' on Android to `chrome_public_apk'. This
will catch any code change that affects the shipped Chrome APK.
Bug: 1254719
Change-Id: Id390166f346b89c652d1fcfdb6708eadeb3fcc30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276753
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
Cr-Commit-Position: refs/heads/main@{#941167}
diff --git a/BUILD.gn b/BUILD.gn
index 7baee87..d6b29b6 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -880,8 +880,9 @@
# other than X11 Ozone backends.
if (enable_remoting && ((is_linux && ozone_platform_x11) ||
((is_chromeos || is_win) && !use_ozone))) {
- # This group is used for network annotation check test.
- group("shipped_binaries") {
+ # On CQ, run the Traffic Annotation Auditor when a change affects one of these
+ # targets.
+ group("traffic_annotation_auditor_dependencies") {
deps = [
"//chrome:chrome",
"//remoting/client",
@@ -895,6 +896,17 @@
}
}
+if (is_android) {
+ # On CQ, run the Traffic Annotation Auditor when a change affects one of these
+ # targets.
+ group("traffic_annotation_auditor_dependencies") {
+ deps = [
+ "//chrome/android:chrome_public_apk",
+ "//tools/traffic_annotation/summary:annotations_xml",
+ ]
+ }
+}
+
if (is_fuchsia) {
# TODO(https://crbug.com/731217): This can't practically be in //v8 without
# duplicating all the Fuchsia running infrastructure there.
