| commit | ee1a5bd8a900dcc56c2f3e29e224634c43f6e5ac | [log] [tgz] |
|---|---|---|
| author | Mustafa Emre Acer <[email protected]> | Thu Dec 15 22:17:36 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Dec 15 22:17:36 2022 |
| tree | 2416664d5736a90965a3ba2be5d45d2ca56682a8 | |
| parent | cc9ac97057126deb079278bb8117970d1b296bdd [diff] |
Add console message for resources with IDNA deviation chars in hostnames Chrome is planning to switch from IDNA 2008 Transitional Mode to Non-Transitional Mode. This change will result in some hostnames resolving to different IP addresses if the hostname contains an IDNA deviation character. See https://chromestatus.com/feature/5105856067141632 for details. For example, a page containing a subresource like <img src="http://faß.de/image.jpg"> will no longer resolve to http://fass.de/image.jpg in Non-Transitional Mode. We want to warn web developers in advance if they embed a resource with an affected URL. This CL adds a console message on pages embedding such resources if the requestor origin is different than the resource origin (so that we don't warn on an affected domain itself). This is non-trivial because URL processing code presently doesn't keep deviation characters intact. As such, they aren't present in KURLs. This means we can't simply check the hostname of the KURL for deviation characters. This CL adds an additional field to KURL to mark it if the original URL string as present in the HTML of the page contains deviation characters. It then decodes the hostname as IDNA if necessary, before printing the log message. These URLs should be extremely rare, so this shouldn't introduce any significant overhead; memory or performance wise. All of this code is temporary and should be removed once Non-Transitional IDNA is enabled in Chrome. Bug: 694157 Change-Id: I339934bd143194e7763ec326389fde6aa764b555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4080821 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Mustafa Emre Acer <[email protected]> Reviewed-by: Charlie Harrison <[email protected]> Reviewed-by: Tom Sepez <[email protected]> Reviewed-by: Emily Stark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1084016}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.
