commit f44cda23bc95838572e17b4e86495c9afc364cf8
author ricea <ricea@chromium.org> Thu Sep 24 14:08:51 2015
committer Commit bot <commit-bot@chromium.org> Thu Sep 24 14:09:40 2015
tree 73d6b78556fba0d9b994a7d40158222256504190
parent 3bf1fa796bd7b82b31e207811521471ded0ef1be

Use the appropriate variant of IntToString in //components

Using the wrong variant of IntToString() can lead to unexpected
behaviour and bugs. Use the appropriate variant for the type being
converted.

No behaviour change intended.

BUG=505479
TEST=compiled

Review URL: https://codereview.chromium.org/1354253002

Cr-Commit-Position: refs/heads/master@{#350545}

components/gcm_driver/gcm_client_impl_unittest.cc

diff --git a/components/gcm_driver/gcm_client_impl_unittest.cc b/components/gcm_driver/gcm_client_impl_unittest.cc
index 3fbb2e7..27fe726c 100644
--- a/components/gcm_driver/gcm_client_impl_unittest.cc
+++ b/components/gcm_driver/gcm_client_impl_unittest.cc
@@ -984,7 +984,7 @@
 // This test only checks that periodic checkin happens.
 TEST_F(GCMClientImplCheckinTest, PeriodicCheckin) {
   std::map<std::string, std::string> settings;
-  settings["checkin_interval"] = base::IntToString(kSettingsCheckinInterval);
+  settings["checkin_interval"] = base::Int64ToString(kSettingsCheckinInterval);
   settings["checkin_url"] = "http://alternative.url/checkin";
   settings["gcm_hostname"] = "alternative.gcm.host";
   settings["gcm_secure_port"] = "7777";
@@ -1005,7 +1005,7 @@
 
 TEST_F(GCMClientImplCheckinTest, LoadGSettingsFromStore) {
   std::map<std::string, std::string> settings;
-  settings["checkin_interval"] = base::IntToString(kSettingsCheckinInterval);
+  settings["checkin_interval"] = base::Int64ToString(kSettingsCheckinInterval);
   settings["checkin_url"] = "http://alternative.url/checkin";
   settings["gcm_hostname"] = "alternative.gcm.host";
   settings["gcm_secure_port"] = "7777";
@@ -1034,7 +1034,7 @@
 // This test only checks that periodic checkin happens.
 TEST_F(GCMClientImplCheckinTest, CheckinWithAccounts) {
   std::map<std::string, std::string> settings;
-  settings["checkin_interval"] = base::IntToString(kSettingsCheckinInterval);
+  settings["checkin_interval"] = base::Int64ToString(kSettingsCheckinInterval);
   settings["checkin_url"] = "http://alternative.url/checkin";
   settings["gcm_hostname"] = "alternative.gcm.host";
   settings["gcm_secure_port"] = "7777";
@@ -1072,7 +1072,7 @@
 // This test only checks that periodic checkin happens.
 TEST_F(GCMClientImplCheckinTest, CheckinWhenAccountRemoved) {
   std::map<std::string, std::string> settings;
-  settings["checkin_interval"] = base::IntToString(kSettingsCheckinInterval);
+  settings["checkin_interval"] = base::Int64ToString(kSettingsCheckinInterval);
   settings["checkin_url"] = "http://alternative.url/checkin";
   settings["gcm_hostname"] = "alternative.gcm.host";
   settings["gcm_secure_port"] = "7777";
@@ -1117,7 +1117,7 @@
 // This test only checks that periodic checkin happens.
 TEST_F(GCMClientImplCheckinTest, CheckinWhenAccountReplaced) {
   std::map<std::string, std::string> settings;
-  settings["checkin_interval"] = base::IntToString(kSettingsCheckinInterval);
+  settings["checkin_interval"] = base::Int64ToString(kSettingsCheckinInterval);
   settings["checkin_url"] = "http://alternative.url/checkin";
   settings["gcm_hostname"] = "alternative.gcm.host";
   settings["gcm_secure_port"] = "7777";