[Autofill] Introduce about:flags for Autofill Address Save Prompts
After https://crrev.com/c/2695787 lands, there will be a reasonable UI.
It's time to introduce about:flags for the
autofill::features::kAutofillAddressProfileSavePrompt feature.
The flag is currently for desktop platforms only.
Bug: 1135178
Change-Id: I4ed6640f0b835e18b7f14a67ea8625ee86d3e1f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2700555
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Matthias Körber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#855271}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index a83a0855..4fd09fad 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -7104,6 +7104,12 @@
FEATURE_VALUE_TYPE(ash::features::kScalableStatusArea)},
#endif
+ {"autofill-address-save-prompt",
+ flag_descriptions::kEnableAutofillAddressSavePromptName,
+ flag_descriptions::kEnableAutofillAddressSavePromptDescription,
+ kOsWin | kOsMac | kOsLinux | kOsCrOS,
+ FEATURE_VALUE_TYPE(autofill::features::kAutofillAddressProfileSavePrompt)},
+
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index ea4c26cd..ca8ff65 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -258,6 +258,11 @@
"expiry_milestone": 90
},
{
+ "name": "autofill-address-save-prompt",
+ "owners": [ "mamir", "koerber" ],
+ "expiry_milestone": 95
+ },
+ {
"name": "autofill-always-return-cloud-tokenized-card",
"owners": [ "[email protected]", "[email protected]", "[email protected]" ],
"expiry_milestone": 94
@@ -878,7 +883,7 @@
"name": "decouple-sync-from-android-auto-sync",
"owners": [ "[email protected]", "[email protected]" ],
"expiry_milestone": 92
- },
+ },
{
"name": "default-browser-fullscreen-promo-cta-experiment",
"owners": [ "javierrobles", "[email protected]" ],
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 45d8522b..cd90aff 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -539,6 +539,11 @@
const char kEnableAutofillAccountWalletStorageDescription[] =
"Enable the ephemeral storage for account data for autofill.";
+const char kEnableAutofillAddressSavePromptName[] =
+ "Autofill Address Save Prompts";
+const char kEnableAutofillAddressSavePromptDescription[] =
+ "Enable the Autofill address save prompts.";
+
const char kEnableAutofillCreditCardAblationExperimentDisplayName[] =
"Credit card autofill ablation experiment.";
const char kEnableAutofillCreditCardAblationExperimentDescription[] =
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index 6b2232d..2941f6c2 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -339,6 +339,9 @@
extern const char kEnableAutofillAccountWalletStorageName[];
extern const char kEnableAutofillAccountWalletStorageDescription[];
+extern const char kEnableAutofillAddressSavePromptName[];
+extern const char kEnableAutofillAddressSavePromptDescription[];
+
extern const char kEnableAutofillCreditCardAblationExperimentDisplayName[];
extern const char kEnableAutofillCreditCardAblationExperimentDescription[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index bba83aa..d2e89bd 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -45603,6 +45603,7 @@
<int value="313303258" label="WebPaymentsModifiers:disabled"/>
<int value="316182183" label="MediaDocumentDownloadButton:disabled"/>
<int value="317432596" label="DisplayLocking:disabled"/>
+ <int value="317889969" label="AutofillAddressProfileSavePrompt:disabled"/>
<int value="319683583" label="ContentSuggestionsDebugLog:enabled"/>
<int value="320121752" label="DelegateOverscrollSwipes:disabled"/>
<int value="321366101" label="WebXRARDOMOverlay:enabled"/>
@@ -46246,6 +46247,7 @@
<int value="913138924" label="RecurrentInterstitialFeature:disabled"/>
<int value="913855453" label="VirtualKeyboardFloatingResizable:disabled"/>
<int value="916316159" label="disable-new-app-list-mixer"/>
+ <int value="917285134" label="AutofillAddressProfileSavePrompt:enabled"/>
<int value="917561046" label="ConversionMeasurement:disabled"/>
<int value="918046854" label="NtlmV2Enabled:disabled"/>
<int value="918608729" label="finch-seed-min-download-period"/>
