commit | f7f4eb4ce9acbf95f6507392dbb065ce24a59cca | [log] [tgz] |
---|---|---|
author | Jeff Yoon <[email protected]> | Fri Mar 06 18:55:36 2020 |
committer | Commit Bot <[email protected]> | Fri Mar 06 18:55:36 2020 |
tree | f409d8bf96f3149dd8258299fb8b22ca8b6a1203 | |
parent | 2869b5de34257518e1b0433b142100477decd655 [diff] |
Reland "Reland "generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests"" This is a reland of 4ed2234c938a44d36fc3168a493dd9acbb7bb1a7 Original change's description: > generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests > > The existing iOS recipe utilizes an isolate template, and an > isolated.gen.json file to fill the template in per test with > config-variables and path-variables. This isolate template contains > the command arguments to invoke the iOS test runner. > > To support the iOS recipe migration to the Chromium recipe, I use GN to > generate a script per test target instead of the isolate template. The > script is pre-baked with arguments to the test runner (run.py). The > given Swarming task is expected to execute the test by invoking the > generated script. > > Invoking the generated script requires changes to gn_isolate_map.pyl > for each iOS test target, and thus, these changes are only additive. > > * "ios_test_runner_wrapper" template wraps the generate_wrapper target. > It bakes iOS specific arguments into the script, such that it can > launch run.py with the given args. > * ios_eg2_test, ios_eg_test, and test templates have > been updated to utilize the ios_test_runner_wrapper for iOS targets. > * mb.py to skip generated_directory check when writing isolates. > View crbug/ in comments. > > Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64 > Bug: 1055328,912681 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748 > Commit-Queue: Jeff Yoon <[email protected]> > Reviewed-by: Sylvain Defresne <[email protected]> > Reviewed-by: John Budorick <[email protected]> > Cr-Commit-Position: refs/heads/master@{#745105} Bug: 1055328, 912681 Change-Id: Ie7979979365b570369e6b6f750cc9f3006024564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088345 Reviewed-by: John Budorick <[email protected]> Reviewed-by: Sylvain Defresne <[email protected]> Commit-Queue: Jeff Yoon <[email protected]> Cr-Commit-Position: refs/heads/master@{#747797}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.