Omnibox Answer Logging - Add Test
Requested follow-up from
https://chromium.googlesource.com/chromium/src.git/+/80d72d8cd21cf76df583e29676b987ac1e3b90e9
Bug: 950344
Change-Id: If96bf162fc230a6a1fb9d5460748e10d48bacf2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582451
Auto-Submit: Mark Pearson <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654132}
diff --git a/components/omnibox/browser/suggestion_answer_unittest.cc b/components/omnibox/browser/suggestion_answer_unittest.cc
index 2bf0850..6363d1ef 100644
--- a/components/omnibox/browser/suggestion_answer_unittest.cc
+++ b/components/omnibox/browser/suggestion_answer_unittest.cc
@@ -9,6 +9,7 @@
#include "base/json/json_reader.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/test/metrics/histogram_tester.h"
#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -323,3 +324,31 @@
ASSERT_EQ(1U, urls.size());
EXPECT_EQ(GURL("https://gstatic.com/bar.jpg"), urls[0]);
}
+
+TEST(SuggestionAnswerTest, LogAnswerUsed) {
+ {
+ base::HistogramTester histograms;
+ base::Optional<SuggestionAnswer> answer;
+ SuggestionAnswer::LogAnswerUsed(answer);
+ histograms.ExpectUniqueSample(SuggestionAnswer::kAnswerUsedUmaHistogramName,
+ 0, 1);
+ }
+
+ {
+ base::HistogramTester histograms;
+ SuggestionAnswer answer;
+ answer.set_type(8);
+ SuggestionAnswer::LogAnswerUsed(answer);
+ histograms.ExpectUniqueSample(SuggestionAnswer::kAnswerUsedUmaHistogramName,
+ 8, 1);
+ }
+
+ {
+ base::HistogramTester histograms;
+ SuggestionAnswer answer;
+ answer.set_type(5);
+ SuggestionAnswer::LogAnswerUsed(answer);
+ histograms.ExpectUniqueSample(SuggestionAnswer::kAnswerUsedUmaHistogramName,
+ 5, 1);
+ }
+}
