Reland "Unify allow_credentials and credentials_mode on network::ResourceRequest"
This is a reland of 1ccc5eeed0f535fe0c181f1ad3e6f0a05ed7f186
Original change's description:
> Unify allow_credentials and credentials_mode on network::ResourceRequest
>
> Remove allow_credentials, map allow_credentials: false to
> credentials_mode: kOmit and map allow_credentials: true to
> credentials_mode: kInclude.
>
> network::URLLoader cannot handle kSameOrigin. This CL doesn't change
> that. CORSURLLoader translates the value to either kOmit or kInclude.
>
> This works correctly even when OOR-CORS is disabled because in that
> case load flags are set in the renderer. One caveat is we will not
> be able to remove the load flags until we remove the blink-side CORS
> code (M78? M79?) with this change.
>
> This CL removes a validity check for credentials related settings in
> CorsURLLoaderFactory. Originally the check was introduced to check the
> inconsistency between credentials_mode and load flags. After that
> allow_credentials was introduced, and at
> https://crrev.com/c/chromium/src/+/1443976 the logic was changed to
> check the inconsistency between credentials_mode and allow_credentials.
> Now they are merged and we don't need the check.
>
> Bug: 799935
> Change-Id: Ic05b2d41456d91fd3f48416a3a3e8fc98e235756
> Tbr: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695341
> Commit-Queue: Yutaka Hirano <[email protected]>
> Reviewed-by: Tom Sepez <[email protected]>
> Reviewed-by: Greg Levin <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
> Reviewed-by: Friedrich [CET] <[email protected]>
> Reviewed-by: Marc Treib <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Reviewed-by: Vasilii Sukhanov <[email protected]>
> Reviewed-by: Alexei Svitkine <[email protected]>
> Reviewed-by: Matt Menke <[email protected]>
> Reviewed-by: Kyle Milka <[email protected]>
> Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
> Reviewed-by: Mark Pearson <[email protected]>
> Reviewed-by: Rebekah Potter <[email protected]>
> Reviewed-by: Emily Stark <[email protected]>
> Reviewed-by: John Rummell <[email protected]>
> Reviewed-by: Ganggui Tang <[email protected]>
> Reviewed-by: Michael Martis <[email protected]>
> Reviewed-by: Mathias Carlen <[email protected]>
> Reviewed-by: Tsuyoshi Horo <[email protected]>
> Reviewed-by: Patrick Noland <[email protected]>
> Reviewed-by: Tommy Nyquist <[email protected]>
> Reviewed-by: Matt Reynolds <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Roman Sorokin [CET] <[email protected]>
> Reviewed-by: Hiroki Nakagawa <[email protected]>
> Reviewed-by: Takashi Toyoshima <[email protected]>
> Reviewed-by: David Benjamin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#681698}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Bug: 799935
Change-Id: Iec8067b3fed29bd6845077f5dc9c564d6640b6ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722274
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#681719}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d80498323e08ace69936c542b6ed907fc7f523c
1 file changed
