commit | 1bd37356f72d8e3b999e6418eb4ed156ee2f3142 | [log] [tgz] |
---|---|---|
author | Nico Weber <[email protected]> | Wed Nov 30 13:32:53 2022 |
committer | Copybara-Service <[email protected]> | Wed Nov 30 13:46:06 2022 |
tree | 2491b1b06d541231e61588a7b1576ed796a62d4f | |
parent | cef84865f573282afba8329c349c193cc1bb962c [diff] |
Enable deprecation warnings on deps of jsoncpp on iOS and macOS jsoncpp adds -Wno-deprecated-declarations in a public_config, pushing it to all its deps. In general, -Wno warning flags should always be in configs, very rarely in public_configs. Enable the warning on iOS and mac now that things build with it enabled. (This required quite a bit of cleanup, see bug.) Also reorganize the file a bit to remove redundancy. This part has no intentional behavior change. https://chromium-review.googlesource.com/c/chromium/src/+/3424283 tried to do this on iOS, but I think it got the parentheses wrong so that it didn't have an effect. Bug: 983223 Change-Id: I45add2fa51f9ff5c2180ac81c571a70226cfbec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066799 Auto-Submit: Nico Weber <[email protected]> Reviewed-by: Sylvain Defresne <[email protected]> Commit-Queue: Nico Weber <[email protected]> Cr-Commit-Position: refs/heads/main@{#1077440} NOKEYCHECK=True GitOrigin-RevId: 282da71f6379aa6b263638d4f6e9f0dd2bffaea9