commit 8789c550faf4587527faf0bd4f6c6c5c64a04ae2
author Michael Niedermayer <michael@niedermayer.cc> Mon May 13 00:05:56 2024
committer Michael Niedermayer <michael@niedermayer.cc> Wed May 15 01:53:24 2024
tree ef72390103595e9aa548e38883b0173c89c98fe8
parent b0093ab8a3d34bf2fefd6665464cc343a9ef0d53

avcodec/qsvdec: Check av_image_get_buffer_size() for failure

Fixes: CID1477406 Improper use of negative value

Sponsored-by: Sovereign Tech Fund
Reviewed-by: "Xiang, Haihao" <haihao.xiang@intel.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

libavcodec/qsvdec.c

diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c
index ed0bfe4..a51ddac 100644
--- a/libavcodec/qsvdec.c
+++ b/libavcodec/qsvdec.c
@@ -379,9 +379,12 @@
 
     q->frame_info = param->mfx.FrameInfo;
 
-    if (!avctx->hw_frames_ctx)
-        q->pool = av_buffer_pool_init(av_image_get_buffer_size(avctx->pix_fmt,
-                    FFALIGN(avctx->width, 128), FFALIGN(avctx->height, 64), 1), av_buffer_allocz);
+    if (!avctx->hw_frames_ctx) {
+        ret = av_image_get_buffer_size(avctx->pix_fmt, FFALIGN(avctx->width, 128), FFALIGN(avctx->height, 64), 1);
+        if (ret < 0)
+            return ret;
+        q->pool = av_buffer_pool_init(ret, av_buffer_allocz);
+    }
     return 0;
 }