commit b5534b94df7f9f5b3b5cd2bbc5eec98a360d2f96
author Paul B Mahol <onemda@gmail.com> Tue Feb 14 08:46:46 2023
committer Paul B Mahol <onemda@gmail.com> Tue Feb 14 21:29:33 2023
tree 57e3359fe1a2e6f8e76dd170b1eeff4779bc609b
parent 02ddfeadbee52c1ad8c023a93594a8cb957e11db

avcodec/rka: fix lossy mode decoding

libavcodec/rka.c

diff --git a/libavcodec/rka.c b/libavcodec/rka.c
index f479942..7b3ba77 100644
--- a/libavcodec/rka.c
+++ b/libavcodec/rka.c
@@ -161,9 +161,9 @@
     if ((avctx->extradata[15] & 4) != 0)
         cmode = -cmode;
 
-    s->ch[0].cmode = s->ch[1].cmode = cmode;
-    s->ch[0].cmode2 = -s->ch[0].cmode;
-    s->ch[1].cmode2 = -s->ch[1].cmode;
+    s->ch[0].cmode = s->ch[1].cmode = cmode < 0 ? 2 : cmode;
+    s->ch[0].cmode2 = cmode < 0 ? FFABS(cmode) : 0;
+    s->ch[1].cmode2 = cmode < 0 ? FFABS(cmode) : 0;
     av_log(avctx, AV_LOG_DEBUG, "cmode: %d\n", cmode);
 
     return 0;
@@ -662,7 +662,9 @@
     return 0;
 }
 
-static const uint8_t tab[] = { 0, 3, 3, 2, 2, 1, 1, 1, 1 };
+static const uint8_t tab[16] = {
+    0, 3, 3, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0
+};
 
 static int decode_filter(RKAContext *s, ChContext *ctx, ACoder *ac, int off, unsigned size)
 {
@@ -729,7 +731,7 @@
                 }
                 ctx->buf0[off] = ctx->buf1[off] + ctx->buf0[off + -1];
             } else {
-                val = val * (1 << ctx->cmode & 0x1f);
+                val <<= ctx->cmode;
                 sum += ctx->buf0[off + -1] + val;
                 switch (s->bps) {
                 case 16: sum = av_clip_int16(sum); break;