commit | 6678906cf890fea0ba6d7f8e5f553d230c014f43 | [log] [tgz] |
---|---|---|
author | Liviu Rau <[email protected]> | Mon May 05 17:55:19 2025 |
committer | LUCI CQ <[email protected]> | Mon May 05 17:55:19 2025 |
tree | a86f50a78464e4e22bcd2290cb698f4196fb05ab | |
parent | d66abd0ede59de8c808feca5649e1f9d0b642445 [diff] |
Revert "Reland "Use bundled python to run gn"" This reverts commit 49fcbee29e78d9307f37037223dcc99b0bc7df8a. Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview Bug: 414312048 Original change's description: > Reland "Use bundled python to run gn" > > This reverts commit a3cdfed6c4f175036560721de6f8b90bc658d09a. > > Reason for revert: > https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed > > Original change's description: > > Revert "Use bundled python to run gn" > > > > This reverts commit fa8fc854e1766b86f10c9a15902cf3cc23adaac2. > > > > Reason for revert: Most likley culprit for consistent failure > > to generate orderfiles (see crbug.com/414312048). > > > > Bug: 414312048 > > > > Original change's description: > > > Use bundled python to run gn > > > > > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515 > > > Reviewed-by: Junji Watanabe <[email protected]> > > > Reviewed-by: Takuto Ikuta <[email protected]> > > > Auto-Submit: Fumitoshi Ukai <[email protected]> > > > Commit-Queue: Fumitoshi Ukai <[email protected]> > > > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846 > > Owners-Override: Friedrich Hauser <[email protected]> > > Auto-Submit: Friedrich Hauser <[email protected]> > > Bot-Commit: Rubber Stamper <[email protected]> > > Commit-Queue: Rubber Stamper <[email protected]> > > Bug: 414312048 > Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176 > Commit-Queue: Fumitoshi Ukai <[email protected]> > Reviewed-by: Takuto Ikuta <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Reviewed-by: Junji Watanabe <[email protected]> Bug: 414312048 Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888 Commit-Queue: Garrett Beaty <[email protected]> Reviewed-by: Garrett Beaty <[email protected]> Owners-Override: Garrett Beaty <[email protected]> Auto-Submit: Liviu Rau <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
Tools for working with Chromium development. It requires python 3.8.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
Also, includes shell script/batch file for tools required to build chromium, e.g.
gn
: a meta-build system that generates build files for Ninjaautoninja
: a wrapper for siso
and ninja
.siso
: a build tool that aims to significantly speed up Chromium's build.ninja
: a small build system with a focus on speed. deprecated by Siso.These shell script/batch file runs python script with python-bin/python3
that find binaries in chromium checkout, and run with proper setup/check. To use these wrappers, you need to initialize/bootstrap depot_tools (using gclient
, update_depot_tools
or ensure_bootstrap
).
See set-up documentation.
depot_tools is also available in
chromium's third_party/depot_tools: propagated by autoroller.
on builder: infra_internal/recipe_bundles/chrome-internal.googlesource.com/chrome/tools/build bundles depot_tools. propagated by build_internal recipe roller
These depot_tools would not be initialized/bootstrapped (i.e. no python-bin/python3
binary available), so the build tool wrapper won't work, unless it is explicitly initialized by ensure_bootstrap
. Or, directly call the python script instead of using the shell script/batch file.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
Running gclient
will install python3
binary.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r [email protected],[email protected] --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.