Use universal EOL conversion when calling the text editor in gcl.
This was causing issues for windows user with notepad2.
Fix trychange.py on python2.5.
[email protected]
BUG=
TEST=
Review URL: http://codereview.chromium.org/8038028
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102797 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/gcl.py b/gcl.py
index 0c8fbb6..dffc566 100755
--- a/gcl.py
+++ b/gcl.py
@@ -532,7 +532,7 @@
if fail_on_not_found:
ErrorExit("Changelist " + changename + " not found.")
return ChangeInfo(changename, 0, 0, '', None, local_root, None, False)
- content = gclient_utils.FileRead(info_file, 'r')
+ content = gclient_utils.FileRead(info_file)
save = False
try:
values = ChangeInfo._LoadNewFormat(content)
@@ -1137,7 +1137,7 @@
subprocess2.check_call(cmd, shell=True)
except subprocess2.CalledProcessError, e:
ErrorExit('Editor returned %d' % e.returncode)
- result = gclient_utils.FileRead(filename, 'r')
+ result = gclient_utils.FileRead(filename)
finally:
os.remove(filename)
