Google Git
Sign in
chromium / chromium / tools / depot_tools.git / 9ab38c68858c67704f940f901ea9aa713cbfce52
commit9ab38c68858c67704f940f901ea9aa713cbfce52[log] [tgz]
authorAaron Gable <[email protected]>Thu Apr 06 21:36:33 2017
committerCommit Bot <[email protected]>Tue Apr 11 23:10:22 2017
treeb062b907de72cd753cbb5d58953149eab2e5d6ab
parenta6c7d95fbeae93a3974366d1fd03aa6b41301bfb [diff]
Fix gerrit git-cl-status to be simpler and correct

The loop over the messages didn't early-exit when it found
a non-CQ message, so it would continue looking until it
found any message by a non-owner. So all CLs with any comments
by anyone other than the uploader would be in 'reply' state
forever.

This CL fixes that, and also makes some other tweaks to
make the gerrit status code simpler and faster.

Bug: 706460
Change-Id: I5cc06962f5121fe042a315e5e2e205e556eb85da
Reviewed-on: https://chromium-review.googlesource.com/470586
Reviewed-by: Andrii Shyshkalov <[email protected]>
Commit-Queue: Aaron Gable <[email protected]>
1 file changed
tree: b062b907de72cd753cbb5d58953149eab2e5d6ab
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. recipes/
  7. support/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. cbuildbot ⇨ support/chromite_wrapper
  14. chrome_set_ver ⇨ support/chromite_wrapper
  15. cros ⇨ support/chromite_wrapper
  16. cros_sdk ⇨ support/chromite_wrapper
  17. .gitignore
  18. .style.yapf
  19. annotated_gclient.py
  20. appengine_mapper.py
  21. apply_issue
  22. apply_issue.bat
  23. apply_issue.py
  24. auth.py
  25. breakpad.py
  26. buildbucket.py
  27. checkout.py
  28. cipd
  29. cipd.bat
  30. cipd.ps1
  31. cipd_client_version
  32. cit
  33. cit.bat
  34. cit.py
  35. clang-format
  36. clang-format.bat
  37. clang_format.py
  38. clang_format_merge_driver
  39. clang_format_merge_driver.bat
  40. clang_format_merge_driver.py
  41. codereview.settings
  42. commit_queue
  43. commit_queue.bat
  44. commit_queue.py
  45. cpplint.bat
  46. cpplint.py
  47. cpplint_chromium.py
  48. create-ntfs-junction.c
  49. create-ntfs-junction.exe
  50. dart_format.py
  51. depot-tools-auth
  52. depot-tools-auth.bat
  53. depot-tools-auth.py
  54. download_from_google_storage
  55. download_from_google_storage.bat
  56. download_from_google_storage.py
  57. fetch
  58. fetch.bat
  59. fetch.py
  60. fix_encoding.py
  61. gclient
  62. gclient-new-workdir.py
  63. gclient.bat
  64. gclient.py
  65. gclient_completion.sh
  66. gclient_scm.py
  67. gclient_utils.py
  68. gerrit_client.py
  69. gerrit_util.py
  70. git-cache
  71. git-cherry-pick-upload
  72. git-cl
  73. git-crrev-parse
  74. git-crsync
  75. git-drover
  76. git-find-releases
  77. git-footers
  78. git-freeze
  79. git-gs
  80. git-hyper-blame
  81. git-map
  82. git-map-branches
  83. git-mark-merge-base
  84. git-nav-downstream
  85. git-nav-upstream
  86. git-new-branch
  87. git-number
  88. git-rebase-update
  89. git-rename-branch
  90. git-reparent-branch
  91. git-retry
  92. git-runhooks
  93. git-squash-branch
  94. git-thaw
  95. git-upstream-diff
  96. git_cache.py
  97. git_cherry_pick_upload.py
  98. git_cl.py
  99. git_cl_completion.sh
  100. git_common.py
  101. git_dates.py
  102. git_drover.py
  103. git_find_releases.py
  104. git_footers.py
  105. git_freezer.py
  106. git_hyper_blame.py
  107. git_map.py
  108. git_map_branches.py
  109. git_mark_merge_base.py
  110. git_nav_downstream.py
  111. git_new_branch.py
  112. git_number.py
  113. git_rebase_update.py
  114. git_rename_branch.py
  115. git_reparent_branch.py
  116. git_retry.py
  117. git_squash_branch.py
  118. git_upstream_diff.py
  119. gn
  120. gn.bat
  121. gn.py
  122. gsutil.py
  123. LICENSE
  124. my_activity.py
  125. my_reviews.py
  126. ninja
  127. ninja-linux32
  128. ninja-linux64
  129. ninja-mac
  130. ninja.exe
  131. OWNERS
  132. owners.py
  133. owners_finder.py
  134. patch.py
  135. PRESUBMIT.py
  136. presubmit_canned_checks.py
  137. presubmit_support.py
  138. profile.xml
  139. pylint
  140. pylint.py
  141. pylintrc
  142. python_runner.sh
  143. README.gclient.md
  144. README.git-cl.md
  145. README.md
  146. README.testing
  147. repo
  148. rietveld.py
  149. roll-dep
  150. roll-dep-svn
  151. roll-dep-svn.bat
  152. roll-dep.bat
  153. roll_dep.py
  154. roll_dep_svn.py
  155. scm.py
  156. setup_color.py
  157. subcommand.py
  158. subprocess2.py
  159. update_depot_tools
  160. update_depot_tools.bat
  161. upload_to_google_storage.py
  162. WATCHLISTS
  163. watchlists.py
  164. weekly
  165. wtf
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r [email protected],[email protected] --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.