| commit | 9fce213bdbb8512c571c6e14b0302dbb5ecd653e | [log] [tgz] |
|---|---|---|
| author | Takuto Ikuta <[email protected]> | Thu Dec 14 01:44:28 2017 |
| committer | Commit Bot <[email protected]> | Mon Dec 18 23:50:25 2017 |
| tree | 10b8a30e4846f3e7f4b30452306657806f334ae9 | |
| parent | cfb9a236fb19cacf6cab23aa317f2628e3d0fdfb [diff] |
Partial revert of "git_cache: lower max num of .pack files before re-bootstrap on Win." This partially reverts commit d51ed57edb595cd0e13e398925dba8bf2324e77e. Reason for revert: New git client for windows was rolled including fix for slow `git fetch`. I guess smaller pack limit causes frequent bootstrap taking 2~3 minutes longer than the case it does not happen. Let me see what happen if we increase pack limit 9 -> 30. I will increase this to 50 if this won't cause regression again. Original change's description: > git_cache: lower max num of .pack files before re-bootstrap on Win. > > It used to be 50, I think ~9 gives best results for Chromium on Win: > on golo VM, it takes <4 minutes to re-boostrap + git fetch small > delta, assuming zipped git checkout for bootstrap is fresh (~1day). > > For other repos, which are significantly smaller, this change should > have minor effect if at all. > > Test: I tested this using `led` tool on Win7 machines running LUCI > stack extensively. For example, > > * https://ci.chromium.org/swarming/task/3a0102e8c8657410 > shows case with few .pack files, hence just 1 fetch > > * https://ci.chromium.org/swarming/task/3a010282f9fd8010 > shows case with 39 .pack files and so bootstrapping + fetch. > If you look at prior tasks on the same VM, you'd find this: > https://ci.chromium.org/swarming/task/39ffe843d01ed010 > which spent 8 minutes doing 1 incremental fetch with 39 .pack > files. > > **Troopers/Sheriffs**: This change is safe to revert. > However, beware that you should also at the same time revert the recipe > roll of this CL to the repo, in which the failed builder's recipe is > located, typically `chromium/tools/build`. > > Bug: 749709 > Change-Id: I18e2b63283100d466e9fb981a9094862463f6909 > Reviewed-on: https://chromium-review.googlesource.com/787174 > Commit-Queue: Andrii Shyshkalov <[email protected]> > Reviewed-by: Takuto Ikuta <[email protected]> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 749709 Change-Id: I3052abe4a9b53277a60c0791a85355e7a0bbdf8f Reviewed-on: https://chromium-review.googlesource.com/823544 Commit-Queue: Andrii Shyshkalov <[email protected]> Reviewed-by: Andrii Shyshkalov <[email protected]> Reviewed-by: Takuto Ikuta <[email protected]>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r [email protected],[email protected] --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.