| commit | a1fbdff17736899759ae1d320ac684122bef21bd | [log] [tgz] |
|---|---|---|
| author | Yuwei Huang <[email protected]> | Fri Feb 01 21:51:15 2019 |
| committer | Commit Bot <[email protected]> | Fri Feb 01 21:51:15 2019 |
| tree | d122f8f022eea4e409ddc9b42e87fa5123130469 | |
| parent | 4f738c1fe58170ab1bc849381d62d28222920815 [diff] |
Fix filename sorting logic in git_cache.py We have trouble rolling dep of the grpc library. It looks like buildbots use git_cache to download cache of the library from cloud storage, but the way it picks up the latest cache is to do a string sort on the filenames then pick the last one. This won't work if the filenames have digit carrying, say you have both 9999.zip and 10000.zip, then 9999.zip will get picked up. This CL fixes this by implementing a new filename sorting logic that extracts the numeral part of the filename and sort on it. Bug: 927154 Change-Id: I68fce3fe67e55ce5092e7e9dc1dca606b427fe87 Reviewed-on: https://chromium-review.googlesource.com/c/1448954 Commit-Queue: Yuwei Huang <[email protected]> Commit-Queue: Robbie Iannucci <[email protected]> Reviewed-by: Robbie Iannucci <[email protected]>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r [email protected],[email protected] --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.