Simplify code; no need to pass issue arg to GetApprovingReviewers().
The class already knows the issue number.
[email protected]
BUG=
Review URL: https://chromiumcodereview.appspot.com/19976002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@213083 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/git_cl.py b/git_cl.py
index bb07ee0..c1ae3f7 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -683,9 +683,9 @@
return self.RpcServer().get(
'/download/issue%s_%s.diff' % (issue, patchset))
- def GetApprovingReviewers(self, issue):
+ def GetApprovingReviewers(self):
return get_approving_reviewers(
- self.RpcServer().get_issue_properties(int(issue), True))
+ self.RpcServer().get_issue_properties(self.GetIssue(), True))
def SetIssue(self, issue):
"""Set this branch's issue. If issue=0, clears the issue."""
@@ -1577,7 +1577,7 @@
# the commit viewvc url.
# Keep a separate copy for the commit message.
if cl.GetIssue():
- change_desc.update_reviewers(cl.GetApprovingReviewers(cl.GetIssue()))
+ change_desc.update_reviewers(cl.GetApprovingReviewers())
commit_desc = ChangeDescription(change_desc.description)
if cl.GetIssue():
