Google Git
Sign in
chromium / chromium / tools / depot_tools.git / e081cbe5aae6b131955b6c3bd7308d95d650948f
commite081cbe5aae6b131955b6c3bd7308d95d650948f[log] [tgz]
authorIlya Sherman <[email protected]>Wed Aug 16 00:51:04 2017
committerCommit Bot <[email protected]>Wed Aug 16 00:57:56 2017
tree5d89079116f897ff9efe8c38ca6ca6caf9576f89
parent9ff0982ec4987b65ab1acfa859d2d272a3d06852 [diff]
[git cl format] Pass --presubmit flag when formatting from presubmit.

This allows us to skip 'git cl format' for histograms.xml, which in
turn allows us to issue a presubmit error rather than a warning when
that file is malformatted, without running the formatting code twice.
The formatter is somewhat slow for this file, so it's helpful to avoid
duplicating that work.

BUG=none
TEST=none
[email protected]

Change-Id: Ia86d45c7c56a9f89db34ca7175ef686589084f85
Reviewed-on: https://chromium-review.googlesource.com/569105
Commit-Queue: Ilya Sherman <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
2 files changed
tree: 5d89079116f897ff9efe8c38ca6ca6caf9576f89
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. recipes/
  7. support/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. cbuildbot ⇨ support/chromite_wrapper
  14. chrome_set_ver ⇨ support/chromite_wrapper
  15. cros ⇨ support/chromite_wrapper
  16. cros_sdk ⇨ support/chromite_wrapper
  17. .gitattributes
  18. .gitignore
  19. .style.yapf
  20. annotated_gclient.py
  21. appengine_mapper.py
  22. apply_issue
  23. apply_issue.bat
  24. apply_issue.py
  25. auth.py
  26. autoninja
  27. autoninja.bat
  28. autoninja.py
  29. breakpad.py
  30. buildbucket.py
  31. checkout.py
  32. cipd
  33. cipd.bat
  34. cipd.ps1
  35. cipd_bin_setup.bat
  36. cipd_bin_setup.sh
  37. cipd_client_version
  38. cipd_manifest.txt
  39. cit
  40. cit.bat
  41. cit.py
  42. clang-format
  43. clang-format.bat
  44. clang_format.py
  45. clang_format_merge_driver
  46. clang_format_merge_driver.bat
  47. clang_format_merge_driver.py
  48. codereview.settings
  49. commit_queue
  50. commit_queue.bat
  51. commit_queue.py
  52. cpplint.bat
  53. cpplint.py
  54. cpplint_chromium.py
  55. dart_format.py
  56. depot-tools-auth
  57. depot-tools-auth.bat
  58. depot-tools-auth.py
  59. download_from_google_storage
  60. download_from_google_storage.bat
  61. download_from_google_storage.py
  62. fetch
  63. fetch.bat
  64. fetch.py
  65. fix_encoding.py
  66. gclient
  67. gclient-new-workdir.py
  68. gclient.bat
  69. gclient.py
  70. gclient_completion.sh
  71. gclient_eval.py
  72. gclient_scm.py
  73. gclient_utils.py
  74. gerrit_client.py
  75. gerrit_util.py
  76. git-cache
  77. git-cherry-pick-upload
  78. git-cl
  79. git-crrev-parse
  80. git-crsync
  81. git-drover
  82. git-find-releases
  83. git-footers
  84. git-freeze
  85. git-gs
  86. git-hyper-blame
  87. git-map
  88. git-map-branches
  89. git-mark-merge-base
  90. git-nav-downstream
  91. git-nav-upstream
  92. git-new-branch
  93. git-number
  94. git-rebase-update
  95. git-rename-branch
  96. git-reparent-branch
  97. git-retry
  98. git-runhooks
  99. git-squash-branch
  100. git-thaw
  101. git-upstream-diff
  102. git_cache.py
  103. git_cherry_pick_upload.py
  104. git_cl.py
  105. git_cl_completion.sh
  106. git_common.py
  107. git_dates.py
  108. git_drover.py
  109. git_find_releases.py
  110. git_footers.py
  111. git_freezer.py
  112. git_hyper_blame.py
  113. git_map.py
  114. git_map_branches.py
  115. git_mark_merge_base.py
  116. git_nav_downstream.py
  117. git_new_branch.py
  118. git_number.py
  119. git_rebase_update.py
  120. git_rename_branch.py
  121. git_reparent_branch.py
  122. git_retry.py
  123. git_squash_branch.py
  124. git_upstream_diff.py
  125. gn
  126. gn.bat
  127. gn.py
  128. gsutil.py
  129. led
  130. led.bat
  131. LICENSE
  132. my_activity.py
  133. my_reviews.py
  134. ninja
  135. ninja-linux32
  136. ninja-linux64
  137. ninja-mac
  138. ninja.exe
  139. OWNERS
  140. owners.py
  141. owners_finder.py
  142. patch.py
  143. PRESUBMIT.py
  144. presubmit_canned_checks.py
  145. presubmit_support.py
  146. profile.xml
  147. pylint
  148. pylint.py
  149. pylintrc
  150. python_runner.sh
  151. README.gclient.md
  152. README.git-cl.md
  153. README.md
  154. README.testing
  155. repo
  156. rietveld.py
  157. roll-dep
  158. roll-dep-svn
  159. roll-dep-svn.bat
  160. roll-dep.bat
  161. roll_dep.py
  162. roll_dep_svn.py
  163. scm.py
  164. setup_color.py
  165. split_cl.py
  166. subcommand.py
  167. subprocess2.py
  168. update_depot_tools
  169. update_depot_tools.bat
  170. update_depot_tools_toggle.py
  171. upload_to_google_storage.py
  172. vpython
  173. vpython.bat
  174. WATCHLISTS
  175. watchlists.py
  176. weekly
  177. wtf
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r [email protected],[email protected] --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.