| commit | 01652c17e116baa8ebd7083e8cbc3dede513ac9e | [log] [tgz] |
|---|---|---|
| author | Amanda Deacon <[email protected]> | Thu Jan 14 00:07:44 2021 |
| committer | Commit Bot <[email protected]> | Mon Jan 25 03:31:30 2021 |
| tree | 4fa2be0611424952390eb570106ed5944e294b46 | |
| parent | 35482ec5c87bc239d1e0f96dc370a42bf8427fab [diff] |
Uprev new code and remove C++17 workarounds. These changes have undergone internal review prior to open-sourcing. This CL was created by running the export_to_chromeos.sh export script, with manual updates to BUILD.gn. The upstream libtextclassifier code in google3 is current as of cl/351124900. Changes to the export script since the previous uprev can be seen in cl/348401862. This CL contains only refactoring changes. It is not expected to introduce any functional/feature changes. BUG=b:174953443 TEST=chromeos: (in conjunction with minor libtextclassifier ebuild TEST=changes) ML Service unit tests for tclib pass. TEST=Manual testing of Quick Answers on DUT (e.g. QA popup visible TEST=on right-clicking non-English words). Cq-Depend: 2627533 Change-Id: Ie560e5c10c0169fa55792572371adb0c49478a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/libtextclassifier/+/2628507 Tested-by: Amanda Deacon <[email protected]> Commit-Queue: Amanda Deacon <[email protected]> Reviewed-by: Honglin Yu <[email protected]> Reviewed-by: Andrew Moylan <[email protected]>
A library for on-device text classification (address, telephone number, emails etc.).
To use libtextclassifier, one also needs to install a flatbuffer model defined in “model.fbs”. For simplicity, this model file will be installed in the ebuild of ml-service.
And libtextclassifier currently depends on the chrome-icu package which requires explicitly initializing the icu data, just like chrome.
The ml-service is currently the only user of this library. If another library in Chrome OS also wants to use it, please let the owners of ml-service and libtextclassifier know because then,