| commit | 18769f21061533932aa39c99740267e3cb4bd3f7 | [log] [tgz] |
|---|---|---|
| author | Michael Liao <[email protected]> | Thu Dec 12 19:01:25 2019 |
| committer | Commit Bot <[email protected]> | Thu Dec 12 19:12:26 2019 |
| tree | 09a15eac050337c21773f35b582bdb4a5e3a95c9 | |
| parent | 3e88433ce80f5c228ff001155ee980a8f3ff5495 [diff] [blame] |
[Common - Data Grids]: bundling data grid parameters + Adding required name field for all data grids Issue: - Data grids in DevTools do not have an aria-label - There are a ton of DataGrid parameters and adding one is messy Changes: - Naming all data grids - Created DataGrid.Datagrid.Parameters type to hold data grid parameters (including a required gridName field) Bug: 963183 Change-Id: I83b130d468fb80034be264b45b86b799f650e978 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891652 Commit-Queue: Michael Liao <[email protected]> Reviewed-by: Robert Paveza <[email protected]>
diff --git a/front_end/console/ConsoleViewMessage.js b/front_end/console/ConsoleViewMessage.js index 9e96df3..6ed835e 100644 --- a/front_end/console/ConsoleViewMessage.js +++ b/front_end/console/ConsoleViewMessage.js
@@ -190,7 +190,7 @@ const columnDisplayNames = columnNames.map(name => name === rawValueColumnSymbol ? Common.UIString('Value') : name); if (flatValues.length) { - this._dataGrid = DataGrid.SortableDataGrid.create(columnDisplayNames, flatValues); + this._dataGrid = DataGrid.SortableDataGrid.create(columnDisplayNames, flatValues, ls`Console`); this._dataGrid.setStriped(true); this._dataGrid.setFocusable(false);