| commit | 3cccb4f51ba778630135a7dc2143c93271b8bd56 | [log] [tgz] |
|---|---|---|
| author | Tim van der Lippe <[email protected]> | Fri May 01 13:57:17 2020 |
| committer | Commit Bot <[email protected]> | Mon May 04 11:09:51 2020 |
| tree | 7899f8ac468b07ac1c99c9e0073ddc8fc0abced1 | |
| parent | fc91ecc14c807fa98a0c4bd9767f156f1befe0d5 [diff] [blame] |
Complete typecheck of sdk/NetworkManager.js with TypeScript What we learnt/changed: - For invoke_* commands, allow the omission of the request object, by adding an initializer in the generated code. [email protected] Bug: 1011811 Change-Id: I04ee0eec703bdcc0235bc5a4a41387af72f912a7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2173374 Commit-Queue: Tim van der Lippe <[email protected]> Reviewed-by: Paul Lewis <[email protected]>
diff --git a/front_end/console/ConsoleViewMessage.js b/front_end/console/ConsoleViewMessage.js index e4c78f4..fcb7621 100644 --- a/front_end/console/ConsoleViewMessage.js +++ b/front_end/console/ConsoleViewMessage.js
@@ -314,7 +314,7 @@ this._selectableChildren.push({element: linkElement, forceSelect: () => linkElement.focus()}); messageElement.appendChild(linkElement); if (request.failed) { - messageElement.createTextChildren(' ', request.localizedFailDescription); + messageElement.createTextChildren(' ', request.localizedFailDescription || ''); } if (request.statusCode !== 0) { messageElement.createTextChildren(' ', String(request.statusCode));