Migrate SDK.TracingModel and TracingManager to models/trace
To avoid circular dependencies when we need to use the SDK module in the
new engine, this CL moves the TracingModel and Manager into models/trace
and updates references across the codebase.
Note that some unit test files (TracingModel_test and
TraceSDKServices_test) have not been moved and need to be relocated now
that their implementation is in models/trace. However this CL is already
large enough so I will do that in a follow-up CL.
Bug: 1462575
Change-Id: Iee0cd7a697fd2124c325bc79901fb5ce0c4c877f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4661345
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Andres Olivares <[email protected]>
Reviewed-by: Nancy Li <[email protected]>
diff --git a/front_end/Tests.js b/front_end/Tests.js
index 083f87f..c03005a 100644
--- a/front_end/Tests.js
+++ b/front_end/Tests.js
@@ -38,7 +38,6 @@
*/
(function createTestSuite(window) {
-
const TestSuite = class {
/**
* Test suite for interactive UI tests.
@@ -149,6 +148,7 @@
self.runtime.loadLegacyModule('core/host/host-legacy.js'),
self.runtime.loadLegacyModule('ui/legacy/legacy-legacy.js'),
self.runtime.loadLegacyModule('models/workspace/workspace-legacy.js'),
+ self.runtime.loadLegacyModule('models/trace/trace-legacy.js'),
]);
this.reportOk_();
} catch (e) {
@@ -429,8 +429,8 @@
test.assertTrue(
request.timing.receiveHeadersEnd - request.timing.connectStart >= 70,
'Time between receiveHeadersEnd and connectStart should be >=70ms, but was ' +
- 'receiveHeadersEnd=' + request.timing.receiveHeadersEnd + ', connectStart=' +
- request.timing.connectStart + '.');
+ 'receiveHeadersEnd=' + request.timing.receiveHeadersEnd +
+ ', connectStart=' + request.timing.connectStart + '.');
test.assertTrue(
request.responseReceivedTime - request.startTime >= 0.07,
'Time between responseReceivedTime and startTime should be >=0.07s, but was ' +
@@ -484,7 +484,6 @@
};
TestSuite.prototype.testConsoleOnNavigateBack = function() {
-
function filteredMessages() {
return SDK.ConsoleModel.allMessagesUnordered().filter(a => a.source !== Protocol.Log.LogEntrySource.Violation);
}
@@ -1075,11 +1074,13 @@
self.SDK.targetManager.addModelListener(
SDK.NetworkManager, SDK.NetworkManager.Events.ResponseReceived, onResponseReceived);
- this.evaluateInConsole_(`
+ this.evaluateInConsole_(
+ `
let img = document.createElement('img');
img.src = "${url}";
document.body.appendChild(img);
- `, () => {});
+ `,
+ () => {});
let count = 0;
function onResponseReceived(event) {
@@ -1390,7 +1391,7 @@
this.assertEquals(childFrameOutput, await takeLogs(self.SDK.targetManager.targets()[1]));
await inputAgent.invoke_dispatchKeyEvent({type: 'keyDown', key: 'a'});
- await runtimeAgent.invoke_evaluate({expression: "document.querySelector('iframe').focus()"});
+ await runtimeAgent.invoke_evaluate({expression: 'document.querySelector(\'iframe\').focus()'});
await inputAgent.invoke_dispatchKeyEvent({type: 'keyDown', key: 'a'});
parentFrameOutput = 'Event type: keydown';
this.assertEquals(parentFrameOutput, await takeLogs(self.SDK.targetManager.targets()[0]));
